From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open Date: Mon, 18 Dec 2017 10:05:56 -0600 Message-ID: <929926a6-f1d2-9c4c-7788-d5d9caf97e4d@codeaurora.org> References: <1513576667-2967-1-git-send-email-hpuranik@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Hemanth Puranik , netdev , linux-kernel Return-path: In-Reply-To: <1513576667-2967-1-git-send-email-hpuranik@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 12/17/2017 11:57 PM, Hemanth Puranik wrote: > This patch fixes the order of mac_up and sgmii_open for the > reasons noted below: > > - If open takes more time(if the SGMII block is not responding or > if we want to do some delay based task) in this situation we > will hit NETDEV watchdog > - The main reason : We should signal to upper layers that we are > ready to receive packets "only" when the entire path is initialized > not the other way around, this is followed in the reset path where > we do mac_down, sgmii_reset and mac_up. This also makes the driver > uniform across the reset and open paths. > - In the future there may be need for delay based tasks to be done in > sgmii open which will result in NETDEV watchdog > - As per the documentation the order of init should be sgmii, mac, rings > and DMA > > Signed-off-by: Hemanth Puranik Acked-by: Timur Tabi -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.