From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2A8C282C0 for ; Sat, 26 Jan 2019 00:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 149EC218F0 for ; Sat, 26 Jan 2019 00:29:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dv3F2WG0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbfAZA3E (ORCPT ); Fri, 25 Jan 2019 19:29:04 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:32996 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfAZA3D (ORCPT ); Fri, 25 Jan 2019 19:29:03 -0500 Received: by mail-pg1-f193.google.com with SMTP id z11so4875472pgu.0 for ; Fri, 25 Jan 2019 16:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1bVeoWeaGaKpfdtPZDTdtAyYzfFIvzQWzMT0Vf8xIOU=; b=Dv3F2WG0iqT7HvVBvGWI+MgEJbtnmeZ4hgaMyYL0dAj56ElW6XF11HykCDGJmeaA0n waSWgpJyuNPpKlm7VFOoP/vkAvBIuT6UjlZVC4+5df9NBleY7If4ciZnMTzQ4dexXHkM DpM63Z8esXVyy5q/IXfzhp9pOHnyHzcLb9tOeCa2r0Qc34VsNQpeK3agFDz+evJFfIOk W0RjdRb550RZxILcpab1TwQgxfp5pQSD232zDtQuds7yaNgL2nN1rBv5+NTNA3D2RtYa x8XU/HWNQaKAIrxhK1RTyXbC8bZBRl3Mn6mEk1+rBB8E4HGCWoiX2ZfR+KptGRNO2gV4 vCrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1bVeoWeaGaKpfdtPZDTdtAyYzfFIvzQWzMT0Vf8xIOU=; b=k1edWlkCHLS8EExZ0aWfxwK7rnBf6H1c8LTZvx12BbfpBAmQOmhA3d9wfNGJLFM+QL N/xecr4ObScdbAfpzvlxI4eqT24wHgSDRqpKXhBnkas4OJJHmHsjCD7lydMjNXT2pXyF IFLVjFqGHbS3+f5nWYgxRi+M0u+V4gBt3lyttnykWYqUoh/T1F6kyh9qfNgvuen7+x3W k2yO4lfM+vJwBHgSX/o3yLU/tKcZj+O6sdYCjuDQElAqm5Icct76iFn2Z4Y2kzCAZpjp yTU1SAF6i2YjdWOGJf35O/dR6vPjNSjX4EstgRnKVIj++ehlXuULPXoj+r+qUusn6OYc lOqQ== X-Gm-Message-State: AJcUukf/kt+kNaIw0mTVE4j/tXOWormRd6cLBpefr/XSJWiJvMCmXetw aRQNd1e3RF5oFFtimLgEIFk= X-Google-Smtp-Source: ALg8bN5w4ELcAieNshDEsHKG7kX/ahQtgQ1H94oZHOUgC4N6eON9/qt/q59dfDaxxUSpSJaP392cDA== X-Received: by 2002:a62:4c:: with SMTP id 73mr12884433pfa.24.1548462542971; Fri, 25 Jan 2019 16:29:02 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:795a:c9ad:c0d4:74ef? ([2601:282:800:fd80:795a:c9ad:c0d4:74ef]) by smtp.googlemail.com with ESMTPSA id u29sm64910494pgn.23.2019.01.25.16.29.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 16:29:01 -0800 (PST) Subject: Re: [PATCH bpf-next v2 0/3] bpf: add BPF_LWT_ENCAP_IP option to bpf_lwt_push_encap To: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org Cc: Peter Oskolkov , Willem de Bruijn References: <20190124193418.81674-1-posk@google.com> From: David Ahern Message-ID: <929c9fb1-6257-4bf7-d218-ed708d0ae42d@gmail.com> Date: Fri, 25 Jan 2019 17:29:00 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190124193418.81674-1-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/24/19 12:34 PM, Peter Oskolkov wrote: > This patchset implements BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap > BPF helper. It enables BPF programs (specifically, BPF_PROG_TYPE_LWT_IN > and BPF_PROG_TYPE_LWT_XMIT prog types) to add IP encapsulation headers > to packets (e.g. IP/GRE, GUE, IPIP). > > This is useful when thousands of different short-lived flows should be > encapped, each with different and dynamically determined destination. > Although lwtunnels can be used in some of these scenarios, the ability > to dynamically generate encap headers adds more flexibility, e.g. > when routing depends on the state of the host (reflected in global bpf > maps). > > V2 changes: Added flowi-based route lookup, IPv6 encapping, and > encapping on ingress. > > I skimmed over the patches and nothing really jumps out. I do question whether it will work with VRFs. I hope to find time to test it; most likely that will not happen before Monday.