From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eelco Chaudron" Subject: Re: [PATCH iproute2/net-next v2] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics Date: Mon, 01 Oct 2018 12:29:58 +0200 Message-ID: <92F8600A-1C8F-4AF1-B84C-CCDE4120BCBA@redhat.com> References: <20180810115846.15762.3693.stgit@wsfd-netdev20.ntdv.lab.eng.bos.redhat.com> <20180810074454.4af9e5cd@xeon-e3> <52262814-6824-44EF-B10C-C7AD96A0FA57@redhat.com> <4203077A-F558-4C2A-82B2-0B0AA8884240@redhat.com> <20181001111051.44f1253b@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, davem@davemloft.net To: "Stephen Hemminger" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55698 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729216AbeJARHI (ORCPT ); Mon, 1 Oct 2018 13:07:08 -0400 In-Reply-To: <20181001111051.44f1253b@shemminger-XPS-13-9360> Sender: netdev-owner@vger.kernel.org List-ID: On 1 Oct 2018, at 11:10, Stephen Hemminger wrote: > On Mon, 01 Oct 2018 09:08:32 +0200 > "Eelco Chaudron" wrote: > >> On 10 Aug 2018, at 16:48, Eelco Chaudron wrote: >> >>> On 10 Aug 2018, at 16:44, Stephen Hemminger wrote: >>> >>>> On Fri, 10 Aug 2018 07:59:30 -0400 >>>> Eelco Chaudron wrote: >>>> >>>>> + if (bs.bytes >= bs_hw.bytes && bs.packets >= bs_hw.packets) { >>>>> + print_string(PRINT_FP, NULL, "%s", _SL_); >>>>> + print_string(PRINT_FP, NULL, "%s", prefix); >>>>> + print_lluint(PRINT_ANY, "sw_bytes", >>>>> + "Sent software %llu bytes", >>>>> + bs.bytes - bs_hw.bytes); >>>>> + print_uint(PRINT_ANY, "sw_packets", " %u pkt", >>>>> + bs.packets - bs_hw.packets); >>>>> + } >>>>> + } >>>>> + >>>>> + print_string(PRINT_FP, NULL, "%s", _SL_); >>>>> + print_string(PRINT_FP, NULL, "%s", prefix); >>>>> + print_lluint(PRINT_ANY, "hw_bytes", "Sent hardware %llu bytes", >>>>> + bs_hw.bytes); >>>> >>>> What does the output look like? >>> >>> See the two +’es below: >>> >>> $ tc -s filter show dev enp3s0np0 parent ffff: >>> filter protocol ip pref 1 flower chain 0 >>> filter protocol ip pref 1 flower chain 0 handle 0x1 >>> eth_type ipv4 >>> dst_ip 2.0.0.0 >>> src_ip 1.0.0.0 >>> ip_flags nofrag >>> in_hw >>> action order 1: mirred (Egress Redirect to device eth1) stolen >>> index 1 ref 1 bind 1 installed 0 sec used 0 sec >>> Action statistics: >>> Sent 534884742 bytes 8915697 pkt (dropped 0, overlimits 0 >>> requeues 0) >>> + Sent software 187542 bytes 4077 pkt >>> + Sent hardware 534697200 bytes 8911620 pkt >>> backlog 0b 0p requeues 0 >>> cookie 89173e6a44447001becfd486bda17e29 >> >> Hi Stephen, anything else required for this patch to be accepted? >> >> FYI the kernel side of this patch has been excepted on net-next. >> >> Cheers, >> >> Eelco > > David Ahern handles net-next see patchwork > https://patchwork.ozlabs.org/patch/956225/ > > I think he was just waiting for the kernel part to merge. Thanks for making me aware of the patchwork for iproute.