From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: [PATCH RFC 16/18] r8168: use phy_read/write in rtl_readphy/writephy helpers Date: Thu, 21 Dec 2017 21:50:49 +0100 Message-ID: <92aa2477-38b4-b954-3440-c604a0923f5f@gmail.com> References: <83321b2e-8402-26c5-9703-3fe795cc893d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Miller , "netdev@vger.kernel.org" To: Andrew Lunn , Realtek linux nic maintainers , Chun-Hao Lin Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:44123 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755676AbdLUUv1 (ORCPT ); Thu, 21 Dec 2017 15:51:27 -0500 Received: by mail-wm0-f65.google.com with SMTP id t8so18357635wmc.3 for ; Thu, 21 Dec 2017 12:51:26 -0800 (PST) In-Reply-To: <83321b2e-8402-26c5-9703-3fe795cc893d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Instead of accessing mdio_ops directly use phy_read/write in these helpers. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8168.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8168.c b/drivers/net/ethernet/realtek/r8168.c index 91191d178..64c87509d 100644 --- a/drivers/net/ethernet/realtek/r8168.c +++ b/drivers/net/ethernet/realtek/r8168.c @@ -1167,12 +1167,12 @@ static int r8168dp_2_mdio_read(struct rtl8168_private *tp, int reg) static void rtl_writephy(struct rtl8168_private *tp, int location, u32 val) { - tp->mdio_ops.write(tp, location, val); + phy_write(tp->dev->phydev, location, val); } static int rtl_readphy(struct rtl8168_private *tp, int location) { - return tp->mdio_ops.read(tp, location); + return phy_read(tp->dev->phydev, location); } static void rtl_patchphy(struct rtl8168_private *tp, int reg_addr, int value) -- 2.15.1