Re: [RFC net] ovpn: fix race between deleting interface and adding new peer

[Antonio Quartulli <antonio@openvpn.net>]

On 04/05/2026 16:20, Antonio Quartulli wrote:
> This patch is sent as RFC to give the AI a chance to review it once
> again, since it was able to spot a new race condition in its
> previous version.

So we got a "critical" report from sashiko-gemini.

The AI analyzed what happens along the error path, by backtracking all 
callers and checking for potential problems.

It found a potential UAF due to a worker not being disabled when 
free'ing the peer in this early stage.

The analysis seems sound and I will deepen it.

However, this bug is not introduced by this patch.
It just happened that sashiko investigated the error path due to this 
patch introducing a "return -ENODEV".
But the problem existed before because we have other spots where an 
error can be returned.

For this reason this patch now seems to be ok and to cover all issues we 
have found so far.

Once my outstanding PR for net is merged, I will send a new one with 
this fix (and maybe the UAF fix too).


Thanks a lot.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.