From: David Ahern <dsahern@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net-next] fib: remove unnecessary input parameters in fib_default_rule_add
Date: Tue, 2 Jan 2024 08:53:11 -0700 [thread overview]
Message-ID: <92bde58c-eea8-400a-9773-b364208a7326@kernel.org> (raw)
In-Reply-To: <20240102071519.3781384-1-shaozhengchao@huawei.com>
On 1/2/24 12:15 AM, Zhengchao Shao wrote:
> When fib_default_rule_add is invoked, the value of the input parameter
> 'flags' is always 0. Rules uses kzalloc to allocate memory, so 'flags' has
> been initialized to 0. Therefore, remove the input parameter 'flags' in
> fib_default_rule_add.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> include/net/fib_rules.h | 3 +--
> net/core/fib_rules.c | 3 +--
> net/ipv4/fib_rules.c | 6 +++---
> net/ipv4/ipmr.c | 2 +-
> net/ipv6/fib6_rules.c | 4 ++--
> net/ipv6/ip6mr.c | 2 +-
> 6 files changed, 9 insertions(+), 11 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-01-02 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 7:15 [PATCH net-next] fib: remove unnecessary input parameters in fib_default_rule_add Zhengchao Shao
2024-01-02 15:53 ` David Ahern [this message]
2024-01-04 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92bde58c-eea8-400a-9773-b364208a7326@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).