From: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<przemyslaw.kitszel@intel.com>, <jay.bhat@intel.com>,
<ivan.d.barrera@intel.com>, <aleksandr.loktionov@intel.com>,
<larysa.zaremba@intel.com>, <anthony.l.nguyen@intel.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<aleksander.lobakin@intel.com>, <linux-pci@vger.kernel.org>,
<madhu.chittim@intel.com>, <decot@google.com>,
<willemb@google.com>, <sheenamo@google.com>
Subject: Re: [PATCH iwl-next 2/2] idpf: implement pci error handlers
Date: Sun, 12 Apr 2026 07:38:32 -0700 [thread overview]
Message-ID: <92eb35ca-af8d-4f54-99ea-c0532cace217@intel.com> (raw)
In-Reply-To: <adnfeAJHoFoaGYH7@wunner.de>
On 4/10/2026 10:43 PM, Lukas Wunner wrote:
> On Fri, Apr 10, 2026 at 05:39:59PM -0700, Emil Tantilov wrote:
>> +static pci_ers_result_t
>> +idpf_pci_err_slot_reset(struct pci_dev *pdev)
>> +{
>> + struct idpf_adapter *adapter = pci_get_drvdata(pdev);
>> +
>> + pci_restore_state(pdev);
>> + pci_set_master(pdev);
>> + pci_wake_from_d3(pdev, false);
>> + if (readl(adapter->reset_reg.rstat) != 0xFFFFFFFF) {
>> + pci_save_state(pdev);
>> + return PCI_ERS_RESULT_RECOVERED;
>> + }
>
> The pci_save_state() is no longer necessary here, please drop it.
> See commits a2f1e22390ac and 383d89699c50 for details.
Ah, the state_saved check was still there when I last checked and I
missed this change ... I will remove it in v2.
Thanks!
Emil
>
> Thanks,
>
> Lukas
prev parent reply other threads:[~2026-04-12 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 0:39 [PATCH iwl-next 0/2] Introduce IDPF PCI callbacks Emil Tantilov
2026-04-11 0:39 ` [PATCH iwl-next 1/2] idpf: remove conditonal MBX deinit from idpf_vc_core_deinit() Emil Tantilov
2026-04-11 0:39 ` [PATCH iwl-next 2/2] idpf: implement pci error handlers Emil Tantilov
2026-04-11 5:43 ` Lukas Wunner
2026-04-12 14:38 ` Tantilov, Emil S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92eb35ca-af8d-4f54-99ea-c0532cace217@intel.com \
--to=emil.s.tantilov@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivan.d.barrera@intel.com \
--cc=jay.bhat@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sheenamo@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox