From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, David Miller <davem@davemloft.net>
Cc: dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries
Date: Tue, 13 Aug 2019 08:41:18 -0600 [thread overview]
Message-ID: <9306e893-cd43-75a0-9a81-fd2ee0dd44c5@gmail.com> (raw)
In-Reply-To: <20190813071445.GL2428@nanopsycho>
On 8/13/19 1:14 AM, Jiri Pirko wrote:
> Mon, Aug 12, 2019 at 05:28:02PM CEST, davem@davemloft.net wrote:
>> From: Jiri Pirko <jiri@resnulli.us>
>> Date: Mon, 12 Aug 2019 10:36:35 +0200
>>
>>> I understand it with real devices, but dummy testing device, who's
>>> purpose is just to test API. Why?
>>
>> Because you'll break all of the wonderful testing infrastructure
>> people like David have created.
>
> Are you referring to selftests? There is no such test there :(
I have one now and will be submitting it after net merges with net-next.
> But if it would be, could implement the limitations
> properly (like using cgroups), change the tests and remove this
> code from netdevsim?
The intent of this code and test is to have a s/w model similar to how
mlxsw works - responding to notifiers and deciding to reject a change.
You are currently adding (or trying to) more devlink based s/w tests, so
you must see the value of netdevsim as a source of testing.
next prev parent reply other threads:[~2019-08-13 14:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 19:15 [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries David Ahern
2019-08-06 22:32 ` Jakub Kicinski
2019-08-07 6:27 ` Jiri Pirko
2019-08-07 12:39 ` David Ahern
2019-08-07 13:07 ` Jiri Pirko
2019-08-07 19:31 ` David Ahern
2019-08-12 4:02 ` David Miller
2019-08-12 8:36 ` Jiri Pirko
2019-08-12 15:28 ` David Miller
2019-08-13 7:14 ` Jiri Pirko
2019-08-13 14:41 ` David Ahern [this message]
2019-08-13 15:34 ` Jiri Pirko
2019-08-13 17:40 ` David Miller
2019-08-13 20:37 ` Jiri Pirko
2019-08-28 10:37 ` Jiri Pirko
2019-08-28 21:26 ` David Ahern
2019-08-29 6:28 ` Jiri Pirko
2019-08-29 12:54 ` David Ahern
2019-08-29 14:02 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9306e893-cd43-75a0-9a81-fd2ee0dd44c5@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).