From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Toppins <jtoppins@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, liali <liali@redhat.com>
Subject: Re: [PATCH net 0/3] Bonding: fix high prio not effect issue
Date: Fri, 09 Dec 2022 16:01:07 -0800 [thread overview]
Message-ID: <9328.1670630467@famine> (raw)
In-Reply-To: <20221209101305.713073-1-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail.com> wrote:
>When a high prio link up, if there has current link, it will not do
>failover as we missed the check in link up event. Fix it in this patchset
>and add a prio option test case.
>
>Hangbin Liu (2):
> bonding: access curr_active_slave with rtnl_dereference
> bonding: do failover when high prio link up
>
>Liang Li (1):
> selftests: bonding: add bonding prio option test
For the series:
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
The only comment I have is that since prio is a signed value, it
would be nice if the selftest tested negative prio values.
-J
> drivers/net/bonding/bond_main.c | 6 +-
> .../selftests/drivers/net/bonding/Makefile | 3 +-
> .../drivers/net/bonding/option_prio.sh | 246 ++++++++++++++++++
> 3 files changed, 252 insertions(+), 3 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/option_prio.sh
>
>--
>2.38.1
>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2022-12-10 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 10:13 [PATCH net 0/3] Bonding: fix high prio not effect issue Hangbin Liu
2022-12-09 10:13 ` [PATCH net 1/3] bonding: access curr_active_slave with rtnl_dereference Hangbin Liu
2022-12-09 23:46 ` Saeed Mahameed
2022-12-09 23:58 ` Eric Dumazet
2022-12-10 12:28 ` Hangbin Liu
2022-12-10 17:41 ` Eric Dumazet
2022-12-12 1:57 ` Hangbin Liu
2022-12-09 10:13 ` [PATCH net 2/3] bonding: do failover when high prio link up Hangbin Liu
2022-12-10 0:03 ` Saeed Mahameed
2022-12-10 12:23 ` Hangbin Liu
2022-12-09 10:13 ` [PATCH net 3/3] selftests: bonding: add bonding prio option test Hangbin Liu
2022-12-10 0:01 ` Jay Vosburgh [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-12 3:56 [PATCH net 0/3] Bonding: fix high prio not effect issue Hangbin Liu
2022-12-14 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9328.1670630467@famine \
--to=jay.vosburgh@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).