From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "Josh Elsasser" <jelsasser@appneta.com>, "Bjørn Mork" <bjorn@mork.no>
Cc: intel-wired-lan@lists.osuosl.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
Date: Mon, 26 Nov 2018 15:52:02 -0800 [thread overview]
Message-ID: <937675447ad1ec2665d0b6f70390d498a01255d0.camel@intel.com> (raw)
In-Reply-To: <40FD0CE5-973C-4A7F-91BD-66C1A1699223@appneta.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Mon, 2018-11-26 at 09:54 -0800, Josh Elsasser wrote:
> Bjørn Mork <bjorn@mork.no> wrote:
>
> > Not that it matters much I guess, but I think LX SFPs were
> > unsupported
> > at that time. The LX support appears to have been added under the
> > radar
> > while refactoring ixgbe_setup_sfp_modules_X550em in commit
> > e23f33367882
> > ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")
>
> Looks like you’re right. Want me to respin with an additional “Fixes”
> tag?
No need to re-spin the patch, just reply with the additional "Fixes"
tag and if patchwork does not pick it up, I will add it to the patch I
have in my tree for validation and review.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-26 23:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 20:57 [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps Josh Elsasser
2018-11-25 11:07 ` Bjørn Mork
2018-11-26 17:54 ` Josh Elsasser
2018-11-26 23:52 ` Jeff Kirsher [this message]
2018-11-27 0:54 ` [Intel-wired-lan] " Josh Elsasser
2018-11-27 4:52 ` David Miller
2018-11-27 16:27 ` Jeff Kirsher
2018-11-27 18:07 ` Florian Fainelli
2018-11-26 23:35 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=937675447ad1ec2665d0b6f70390d498a01255d0.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jelsasser@appneta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).