From mboxrd@z Thu Jan 1 00:00:00 1970 From: "lipeng (Y)" Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev Date: Tue, 9 Jan 2018 10:48:04 +0800 Message-ID: <937b5edd-8b05-56db-5510-6d09b0004a0b@huawei.com> References: <20180108.203913.1283013651432416478.davem@davemloft.net> <20180108174602.34bee66b@cakuba.netronome.com> <20180108175021.4a769c33@cakuba.netronome.com> <20180108.205440.1825662768273316692.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , To: David Miller , Return-path: In-Reply-To: <20180108.205440.1825662768273316692.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018/1/9 9:54, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 8 Jan 2018 17:50:21 -0800 > >> Oh, I only noticed this extra misleading comment now. Unless each queue >> has a netdev, I don't see how these are per-queue. > If it isn't per-queue I want this change reverted. [patch 12/20 ] add statistics of netdev for ethtool -S, netdev may have multi queue. As discussion here, it is duplicate to add this patch. I revert [patch 12/20 ] , and then test on my board, HNS3 basic function and ethtool -S work well. So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). Thanks Peng Li > . >