From: SF Markus Elfring <elfring@users.sourceforge.net>
To: netdev@vger.kernel.org, Andy Gospodarek <andy@greyhouse.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] bonding: Use seq_putc() in bond_info_show_master()
Date: Tue, 2 May 2017 20:52:55 +0200 [thread overview]
Message-ID: <9395231f-2ebb-dae9-4ef0-514d933fa387@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 20:48:36 +0200
A few single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/bonding/bond_procfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
index d8d4ada034b7..bdc4db184d94 100644
--- a/drivers/net/bonding/bond_procfs.c
+++ b/drivers/net/bonding/bond_procfs.c
@@ -72,7 +72,7 @@ static void bond_info_show_master(struct seq_file *seq)
seq_printf(seq, " (fail_over_mac %s)", optval->string);
}
- seq_printf(seq, "\n");
+ seq_putc(seq, '\n');
if (bond_mode_uses_xmit_hash(bond)) {
optval = bond_opt_get_val(BOND_OPT_XMIT_HASH,
@@ -117,11 +117,11 @@ static void bond_info_show_master(struct seq_file *seq)
if (!bond->params.arp_targets[i])
break;
if (printed)
- seq_printf(seq, ",");
+ seq_putc(seq, ',');
seq_printf(seq, " %pI4", &bond->params.arp_targets[i]);
printed = 1;
}
- seq_printf(seq, "\n");
+ seq_putc(seq, '\n');
}
if (BOND_MODE(bond) == BOND_MODE_8023AD) {
--
2.12.2
reply other threads:[~2017-05-02 18:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9395231f-2ebb-dae9-4ef0-514d933fa387@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).