From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C838934D939 for ; Wed, 4 Mar 2026 15:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639334; cv=none; b=NkK/HxBlW/QoL6fvndda6NqVNoSEhKAmNDeEW4cKeEraxij9q8XQxBC8DpnWuG2ohukY9hvKfTU/SeR7vtczSAeGyFkv40D62AlmrZpr2v/wOqlUQP1WzbqTSALlafv/QezQ367ifLYePKt52XS/4X3ZjXsoeqVHU/Ez4V8icNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639334; c=relaxed/simple; bh=hJ4+IIviYkQQi0IXA+ww8JQAuvRltcrkKqqk8JiMmzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OnBzRZHefRANNCTPoglNWuIACbnnpONOVnVOuF5u+LDn7VtfrZ3p59IWVTsOG0FT/57rv8kaWtqYCqa4/K1E9+EXhPprxrvbd6S8IXluntTR2WaZ194SgCvdzHcxO5aMpQ6+4W5xH8R0Tr5n8880r2LLGEM0m6F2t2n5mObRN8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pwfUaB+4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pwfUaB+4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 203BFC2BCAF; Wed, 4 Mar 2026 15:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772639334; bh=hJ4+IIviYkQQi0IXA+ww8JQAuvRltcrkKqqk8JiMmzY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pwfUaB+4fiZRPevdnFd/pLVHkT/Ziz2Klq6YgsJSbTuETICMaw6OtWl0H3mNHmpux tR3d76thWb/q9xQRAMgwtKDmpUclMoMc2AJCGUxTxJuVnReSWRvi3K++CT6rCH8dQL 5UArPViFgSQN+z2gbm1Z2tMuhYgM9g/X61StjjCY3mgb5qIL0NKncWpTs/89ovz59Z iAhrJL1E9IWTt5JlyJiUBLQTcxmk1svdLv3oGcX4O+aA/cjsm6hE3o8FRYkYr3rflb 1qf2+w0ofccs6c34mY026MM8wOM7rZLXLDsVjgBtf6rUXWvVe3/uCPY8ZzjuolYFoi 8vEpQ9LBhZMkg== Message-ID: <93b5fb6d-7aa0-481f-823f-995ed8ab0e52@kernel.org> Date: Wed, 4 Mar 2026 08:48:53 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] inet_diag: report delayed ack timer information Content-Language: en-US To: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Neal Cardwell , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com References: <20260304094318.1769536-1-edumazet@google.com> From: David Ahern In-Reply-To: <20260304094318.1769536-1-edumazet@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/4/26 2:43 AM, Eric Dumazet wrote: > inet_sk_diag_fill() populates r->idiag_timer with the following > precedence order: > > 1 - Retransmit timer. > 4 - Probe0 timer. > 2 - Keepalive timer. > > This patch adds a new value, last in the list, if other timers > are not active. > > 5 - Delayed ACK timer. > > A corresponding iproute2 patch is needed to replace "unknown" > with "delack": ... > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c > index 9d215485b5c7e7ba29dd53c924f0245439d74af5..e4cb18061aefcc22df04644c00bf5c7db4e150d2 100644 > --- a/net/ipv4/inet_diag.c > +++ b/net/ipv4/inet_diag.c > @@ -298,6 +298,10 @@ int inet_sk_diag_fill(struct sock *sk, struct inet_connection_sock *icsk, > r->idiag_retrans = READ_ONCE(icsk->icsk_probes_out); > r->idiag_expires = > jiffies_delta_to_msecs(icsk->icsk_keepalive_timer.expires - jiffies); > + } else if (timer_pending(&icsk->icsk_delack_timer)) { > + r->idiag_timer = 5; How come the idiag_timer values an enum in include/uapi/linux/inet_diag.h since this is a uapi? > + r->idiag_expires = > + jiffies_delta_to_msecs(icsk_delack_timeout(icsk) - jiffies); > } > > if ((ext & (1 << (INET_DIAG_INFO - 1))) && handler->idiag_info_size) {