From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862A1C43334 for ; Mon, 11 Jul 2022 20:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231709AbiGKUz3 convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2022 16:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbiGKUz3 (ORCPT ); Mon, 11 Jul 2022 16:55:29 -0400 Received: from relay5.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BCBE528A3 for ; Mon, 11 Jul 2022 13:55:28 -0700 (PDT) Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B2B595F8; Mon, 11 Jul 2022 20:55:26 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 409621B; Mon, 11 Jul 2022 20:55:25 +0000 (UTC) Message-ID: <93dc367b01cdfbb68e6edf7367d2f69adfb5d407.camel@perches.com> Subject: Re: [PATCH v3] staging: qlge: Fix indentation issue under long for loop From: Joe Perches To: Greg Kroah-Hartman , Binyi Han Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 11 Jul 2022 13:55:24 -0700 In-Reply-To: References: <20220710210418.GA148412@cloud-MacBookPro> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.1-0ubuntu1 MIME-Version: 1.0 X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 409621B X-Stat-Signature: chopoje3jzpy9qmb7kz8idsut8dic5gc X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18/ZwN4JJSNAALDvoh6AB39oIXKePuMAwU= X-HE-Tag: 1657572925-704760 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2022-07-11 at 10:05 +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 10, 2022 at 02:04:18PM -0700, Binyi Han wrote: > > Fix indentation issue to adhere to Linux kernel coding style, > > Issue found by checkpatch. Change the long for loop into 3 lines. And > > optimize by avoiding the multiplication. > > > > Signed-off-by: Binyi Han > > --- > > v2: > > - Change the long for loop into 3 lines. > > v3: > > - Align page_entries in the for loop to open parenthesis. > > - Optimize by avoiding the multiplication. > > Please do not mix coding style fixes with "optimizations" or logical > changes. This should be multiple patches. > > Also, did you test this change on real hardware? At first glance, it's > not obvious that the code is still doing the same thing, so "proof" of > that would be nice to have. I read the code and suggested the optimization. It's the same logic.