From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: Use __u32 in uapi net_stamp.h Date: Mon, 9 Jul 2018 16:18:07 -0700 Message-ID: <93e9a7b8-4d6b-5772-9a7c-27c766fee50c@gmail.com> References: <20180709230834.14788-1-jesus.sanchez-palencia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net To: Jesus Sanchez-Palencia , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:38593 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753008AbeGIXSJ (ORCPT ); Mon, 9 Jul 2018 19:18:09 -0400 Received: by mail-pf0-f196.google.com with SMTP id x13-v6so4772419pfh.5 for ; Mon, 09 Jul 2018 16:18:09 -0700 (PDT) In-Reply-To: <20180709230834.14788-1-jesus.sanchez-palencia@intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/09/2018 04:08 PM, Jesus Sanchez-Palencia wrote: > We are not supposed to use u32 in uapi, so change the flags member of > struct sock_txtime from u32 to __u32 instead. > > Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time") > Signed-off-by: Jesus Sanchez-Palencia Could you use this patch as an opportunity to tab-align the fields names ? Also you can credit the reporter, as in : Reported-by: Eric Dumazet Thanks !