From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F9BC43381 for ; Tue, 26 Mar 2019 23:44:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A46A22075D for ; Tue, 26 Mar 2019 23:44:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqF43YkG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733042AbfCZXoL (ORCPT ); Tue, 26 Mar 2019 19:44:11 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54487 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731824AbfCZXoL (ORCPT ); Tue, 26 Mar 2019 19:44:11 -0400 Received: by mail-wm1-f66.google.com with SMTP id f3so14475845wmj.4 for ; Tue, 26 Mar 2019 16:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hfsxL9upkUwMaR5/bpo1tzS59s6j6MKLlQzqdYJd+sw=; b=jqF43YkGJxFWlg8ArAe86V5xw+bW8PkSUOYKYXOZg64ETh+yZjOx4VOcbe9DmoeXwS l8r3asUwNu4KjhKkXfGoeRhl/HJ3+8E5Uw2pSy7gbCGRJXpSbSZC01nDpRkslTLlJNwh 4Yp8/8AQbKZO25PUhtESQ6rJBg+vsu4B/TpzYu6ccAZ2QRkp8gF4WovyYYNHXE3TKsah O7sLfIniiJVV46K3vXGIk0UIaNrA5TXDwRRGz31Dg22hUAMZLJIWK4p80kW1nY0I4jOe HCyYqyeAlr6p8fcnafTQA7GuRvt5PEayCY8V9H4SrqyZslFfat6eJqlgeuUqS0loL4wK rJVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hfsxL9upkUwMaR5/bpo1tzS59s6j6MKLlQzqdYJd+sw=; b=liIefEMvs6EwErlHt0dGGjoo9Jhx7wO7kOk7biwlzo0oCaEjyNcYITIhJdu9QRnIfU hzlvEci0Pzyup51ZWIl0EnUhkgQOVUCVwQejWNL3S2NAI3xb6KCLF96ND9u/pwQvZW4/ ICmdBvtDpj+QTvArwT0uJU1ge6U3SgGKAmaJImbzTOjcnMRTEdngafMMNNPnrSargReg 2K39pz2YjWO7kMnD7XtHwJamh1gzBIAEfrjCq3y/vA9SYXj5pI4aAEkfwWSTL+4mtSCb I90z3/6iKMlaN3LVYz6P20rbhJcy9H7RGhUZoSKJgVUwuCnuWTgkb2lbltaZp0Co66tw eAQA== X-Gm-Message-State: APjAAAVPFc94z4FHGRVgL2z8Xw1VlaYVZI7wnyi+p7VU2oC2uJKebFLG MgyOqqf29QaFgo3RrlnweUs= X-Google-Smtp-Source: APXvYqyrlLx+p1jzJ7fB14ewwMBO3yff9CZNR9ZQvlZCcua0OJgLPzNaPJq20+GyJGQOtiH6JSTVIw== X-Received: by 2002:a05:600c:24f:: with SMTP id 15mr1621058wmj.48.1553643849364; Tue, 26 Mar 2019 16:44:09 -0700 (PDT) Received: from [192.168.1.2] ([188.26.228.227]) by smtp.gmail.com with ESMTPSA id j64sm22913738wmb.36.2019.03.26.16.44.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 16:44:08 -0700 (PDT) Subject: Re: [RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver To: Florian Fainelli , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org References: <20190324032346.32394-1-olteanv@gmail.com> <20190324032346.32394-14-olteanv@gmail.com> From: Vladimir Oltean Message-ID: <940b53a1-3fbe-46c3-29dd-677c11a7cf8e@gmail.com> Date: Wed, 27 Mar 2019 01:44:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/26/19 4:24 AM, Florian Fainelli wrote: > > > On 3/23/2019 8:23 PM, Vladimir Oltean wrote: >> Signed-off-by: Vladimir Oltean >> --- >> .../devicetree/bindings/net/dsa/sja1105.txt | 123 ++++++++++++++++++ >> 1 file changed, 123 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/dsa/sja1105.txt >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/sja1105.txt b/Documentation/devicetree/bindings/net/dsa/sja1105.txt >> new file mode 100644 >> index 000000000000..2c82b6fc37e3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/dsa/sja1105.txt >> @@ -0,0 +1,123 @@ >> +NXP SJA1105 switch driver >> +========================= >> + >> +Required properties: >> + >> +- compatible: Must be "nxp,sja1105". Device ID identification (one of >> + E/T/P/Q/R/S) is performed by driver at probe time. Swapping pin-compatible >> + parts is possible with no DTS change. >> + >> +Optional properties: >> + >> +- sja1105,mac-mode, sja1105,phy-mode: Boolean properties that can be assigned >> + under each port node that is MII or RMII (has no effect for RGMII). By >> + default (unless otherwise specified) a port is configured as MAC if it is >> + driving a PHY (phy-handle is present) or as PHY if it is PHY-less (fixed-link >> + specified, presumably because it is connected to a MAC). These properties >> + are required in the case where SJA1105 ports are at both ends of an MII/RMII >> + PHY-less setup. One end would need to have sja1105,mac-mode, while the other >> + sja1105,phy-mode. > > Typically we would be using a fixed-link with an appropriate 'phy-mode' > property to describe a MAC to MAC connection, this may be seen as a > re-purposing PHY-oriented properties though, so I am fine with that binding: > > Reviewed-by: Florian Fainelli > Hi Florian, I don't feel amazing about my solution either, but I don't think I'm understanding what you propose. Something like phy-mode = "rmii-mac" or "rmii-phy" or "mii-mac" or "mii-phy"? Would that require an update of the phy_modes() function and strings? I think the last time when an interface type was split into further subdivisions (RGMII with all its internal delay flavors) it didn't go too well - with lots of bugs introduced simply because drivers failed to grok the newly introduced subtypes as still being RGMII. Thank you, -Vladimir