Re: [PATCH iproute2-next 2/2] f_flower: implement pfcp opts

[Wojciech Drewek <wojciech.drewek@intel.com>]

On 10.04.2024 17:53, Stephen Hemminger wrote:
> On Wed, 10 Apr 2024 12:14:40 +0200
> Wojciech Drewek <wojciech.drewek@intel.com> wrote:
> 
>> +pfcp_opts
>> +.I OPTIONS
>> +doesn't support multiple options, and it consists of a key followed by a slash
>> +and corresponding mask. If the mask is missing, \fBtc\fR assumes a full-length
>> +match. The option can be described in the form TYPE:SEID/TYPE_MASK:SEID_MASK
>> +where TYPE is represented as a 8bit number, SEID is represented by 64bit, both
>> +of them are in hex.
> 
> Best practices in English writing style is to make all clauses have similar
> starting phrase.

pfcp_opts
.I OPTIONS
doesn't support multiple options. It consists of a key followed by a slash
and corresponding mask. If the mask is missing, \fBtc\fR assumes a full-length
match. The option can be described in the form TYPE:SEID/TYPE_MASK:SEID_MASK
where TYPE is represented as a 8bit number, SEID is represented by 64bit. Both
TYPE and SEID are provided in hex.

Does it look better?

> 
> Existing paragraph here is a mess already, so not unique to this.
> That part of tc-flower man page needs some grammar fixes, as well
> as being broken up.