From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net 1/4] ipv6: Only emit append events for appended routes Date: Fri, 15 Jun 2018 08:21:13 -0600 Message-ID: <9431f049-eecd-0c6c-ec57-84e25187b765@gmail.com> References: <20180615132338.14241-1-idosch@mellanox.com> <20180615132338.14241-2-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:36483 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755699AbeFOOVQ (ORCPT ); Fri, 15 Jun 2018 10:21:16 -0400 Received: by mail-pg0-f67.google.com with SMTP id m5-v6so4511155pgd.3 for ; Fri, 15 Jun 2018 07:21:16 -0700 (PDT) In-Reply-To: <20180615132338.14241-2-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/15/18 7:23 AM, Ido Schimmel wrote: > Current code will emit an append event in the FIB notification chain for > any route added with NLM_F_APPEND set, even if the route was not > appended to any existing route. > > This is inconsistent with IPv4 where such an event is only emitted when > the new route is appended after an existing one. > > Align IPv6 behavior with IPv4, thereby allowing listeners to more easily > handle these events. > > Fixes: f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route") > Signed-off-by: Ido Schimmel > Acked-by: Jiri Pirko > --- > net/ipv6/ip6_fib.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Acked-by: David Ahern