* [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt
@ 2019-02-08 0:01 Arun Parameswaran
2019-02-08 0:07 ` Florian Fainelli
2019-02-08 2:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arun Parameswaran @ 2019-02-08 0:01 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn, Vivien Didelot, David S . Miller
Cc: bcm-kernel-feedback-list, netdev, linux-kernel, Arun Parameswaran
Fixes the issues with non BCM58XX chips in the b53 driver
failing, when the irq is not specified in the device tree.
Removed the check for BCM58XX in b53_srab_prepare_irq(),
so the 'port->irq' will be set to '-EXIO' if the irq is not
specified in the device tree.
Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts")
Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized")
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
---
drivers/net/dsa/b53/b53_srab.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c
index 90f514252987..d9c56a779c08 100644
--- a/drivers/net/dsa/b53/b53_srab.c
+++ b/drivers/net/dsa/b53/b53_srab.c
@@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct platform_device *pdev)
/* Clear all pending interrupts */
writel(0xffffffff, priv->regs + B53_SRAB_INTR);
- if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID)
- return;
-
for (i = 0; i < B53_N_PORTS; i++) {
port = &priv->port_intrs[i];
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt
2019-02-08 0:01 [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt Arun Parameswaran
@ 2019-02-08 0:07 ` Florian Fainelli
2019-02-08 2:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-02-08 0:07 UTC (permalink / raw)
To: Arun Parameswaran, Andrew Lunn, Vivien Didelot, David S . Miller
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 2/7/19 4:01 PM, Arun Parameswaran wrote:
> Fixes the issues with non BCM58XX chips in the b53 driver
> failing, when the irq is not specified in the device tree.
>
> Removed the check for BCM58XX in b53_srab_prepare_irq(),
> so the 'port->irq' will be set to '-EXIO' if the irq is not
> specified in the device tree.
>
> Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts")
> Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized")
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Arun!
> ---
> drivers/net/dsa/b53/b53_srab.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c
> index 90f514252987..d9c56a779c08 100644
> --- a/drivers/net/dsa/b53/b53_srab.c
> +++ b/drivers/net/dsa/b53/b53_srab.c
> @@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct platform_device *pdev)
> /* Clear all pending interrupts */
> writel(0xffffffff, priv->regs + B53_SRAB_INTR);
>
> - if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID)
> - return;
> -
> for (i = 0; i < B53_N_PORTS; i++) {
> port = &priv->port_intrs[i];
>
>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt
2019-02-08 0:01 [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt Arun Parameswaran
2019-02-08 0:07 ` Florian Fainelli
@ 2019-02-08 2:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-08 2:19 UTC (permalink / raw)
To: arun.parameswaran
Cc: f.fainelli, andrew, vivien.didelot, bcm-kernel-feedback-list,
netdev, linux-kernel
From: Arun Parameswaran <arun.parameswaran@broadcom.com>
Date: Thu, 7 Feb 2019 16:01:18 -0800
> Fixes the issues with non BCM58XX chips in the b53 driver
> failing, when the irq is not specified in the device tree.
>
> Removed the check for BCM58XX in b53_srab_prepare_irq(),
> so the 'port->irq' will be set to '-EXIO' if the irq is not
> specified in the device tree.
>
> Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts")
> Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized")
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-08 0:01 [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt Arun Parameswaran
2019-02-08 0:07 ` Florian Fainelli
2019-02-08 2:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).