From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7EB1F7065 for ; Tue, 3 Dec 2024 15:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733238218; cv=none; b=gg990RoWxkY2AYak2pQktxGcNywJoDEY7S4rMibyr6b61geWbxdxeM8kE2U2ZFcdXT57I69SZNqwHEG0APmlKQiEqg01TTjiEC/yxdfEvoA17+Zwkrb2+RAIao3gNdSBI52kT54yec4TTcjQ15xq5H+5vrOglpOVJYjnREczVC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733238218; c=relaxed/simple; bh=Y+Nv76JuimdwOlgZdxhPKuAZhbr3eXr/RrZVVR1Jszc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dd8d1G68DXXzH0i7U/TQAN1vbHZy7JD3v1ppaFM9mP7xWTK3ohX8rCuccfLOH9imlcH8edeQyqKo0mdW0yCEUqIU1RiMoEP9zBNMkGlewSs8qvyaSbjhHlFYb51r5EFhRvCsU8DHHgy10CTTtIbxshHdd2E2Ht1lZQ0qIdl2A6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=aLeULJb6; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="aLeULJb6" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-385eaecc213so1540737f8f.1 for ; Tue, 03 Dec 2024 07:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1733238214; x=1733843014; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=UUc2U6b8AsvwMKbUGdD9RXYUFtONNeSR6k1MPBCihcM=; b=aLeULJb6Bgh7WyL+VeFoJp9l0qCJsv7OvahlhAXcQhy37SJoRHTblnXpqdcbTzvXbe Zmae/ZNIenjrvbN1IjPrW6ifBMReqXde1eCzHfP8/ga8CDFU1Y148BTarBJjqs5ofCsK 2DhP4k8t1KV0qmgSlkzGOoXz1IYwxYo4mi4GAO+WU5Khzl4Tx4jb/onJkAgvOQH5sygU aYdy6zjUxoGzSPuzBbH3QI6TgheVHBYM32yJbdvYSdQCb81ZcuUkKbi5p+3cd3XjfESQ SlWHGBewuXdqrpRH8C9F5kl5/0UJ+3tXWQ/Ln7RgMHzco+xH+vo5HbmDRo98XufHC8N5 9mxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733238214; x=1733843014; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UUc2U6b8AsvwMKbUGdD9RXYUFtONNeSR6k1MPBCihcM=; b=Cs9HzTKdi7dQcdgTXsYONjXCDXb8V/Exb39T7VfVQSvxPR5M4XO/69CQuuK6JVXPGw sZgAB1FpAZA9y94KJdAhCni/ZWBhond2ssy6/F6A6R/8Bu9i4S1SQuXK4AUEQacjxk7j 0x4xZ58xCEbjPzdPHxKP5BC/GsYTwdgLbqitbG+4Y4Ox5ekq/m2jhg++x8uCqqocc0po dqV230Ry1U/bL1EqI+pK4IL6F3ykTFuQE6O+PXtpYfm6KlQXV2s9/AxvgbkTanvo6J8K UMqX18jd8qa3YjkQXYCNo4hzmGPJHglt+bEXS3/RAR0ZWygo3a5kxZjc9108UN1Ob/fI DXrQ== X-Forwarded-Encrypted: i=1; AJvYcCXIVogIuZ1aMcu1c21freiKXTo04MmlCeKLh7NPFkCpWKK4s7LQL74hIYKjWwudXviiAAjlsdU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm6ItFQqKTToa3D1LLJzqJ7q9nXbZMjq/4yoDrDd42Ka2j/emi D/gZYhqs7PbOkSA05tn5/0I5CW4TgANtId+GhlSpp63PSz608QwgQ0MYrETu4xg= X-Gm-Gg: ASbGncu3xj74HtITx3+3+yNvYQpDYTCOuf1lJH/IsqhYL+59g/M75RyeMTZiOETrsKA tQCgr5/iab7MyD0Tx7AE+ryqLyhVNPNIqMBdu+djEsQftibr/2u2o2cljQqVySLWTY+nXWRywvp a9cfvzqnBC3rrvx6yQG3n3eCG6Xg6ahaQtroYyqm6MiGWoduBojCzD4xB1zaLaVCN/WnMULkSXK 3eMTvYybZaumt9sjGVtqDsccL6GgsUs6j5fasV/ZDqH5MEt+Up0oILlADZGyYlFfTPJmEEg8V32 2+jjuhdXhyux X-Google-Smtp-Source: AGHT+IGX4qlJajenQzrAt/pIuQUZzcr+mvo9oyzKhTai61NwFS1z9iEGZQMMyKzVXX2SQcLM+nGCGw== X-Received: by 2002:a5d:5c05:0:b0:385:d7f9:f15f with SMTP id ffacd0b85a97d-385d7f9f229mr18702317f8f.19.1733238213983; Tue, 03 Dec 2024 07:03:33 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:138c:c1e3:75bf:72b5? ([2001:67c:2fbc:1:138c:c1e3:75bf:72b5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa76b52bsm224254745e9.18.2024.12.03.07.03.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 07:03:33 -0800 (PST) Message-ID: <943b6994-f87b-4e8b-a5ff-3f6680070cc4@openvpn.net> Date: Tue, 3 Dec 2024 16:04:12 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v12 09/22] ovpn: implement packet processing To: Paolo Abeni , Eric Dumazet , Jakub Kicinski , Donald Hunter , Shuah Khan , sd@queasysnail.net, ryazanov.s.a@gmail.com, Andrew Lunn Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20241202-b4-ovpn-v12-0-239ff733bf97@openvpn.net> <20241202-b4-ovpn-v12-9-239ff733bf97@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/12/2024 15:58, Paolo Abeni wrote: > On 12/2/24 16:07, Antonio Quartulli wrote: >> @@ -286,6 +292,31 @@ struct ovpn_peer *ovpn_peer_get_by_dst(struct ovpn_priv *ovpn, >> return peer; >> } >> >> +/** >> + * ovpn_peer_check_by_src - check that skb source is routed via peer >> + * @ovpn: the openvpn instance to search >> + * @skb: the packet to extract source address from >> + * @peer: the peer to check against the source address >> + * >> + * Return: true if the peer is matching or false otherwise >> + */ >> +bool ovpn_peer_check_by_src(struct ovpn_priv *ovpn, struct sk_buff *skb, >> + struct ovpn_peer *peer) >> +{ >> + bool match = false; >> + >> + if (ovpn->mode == OVPN_MODE_P2P) { >> + /* in P2P mode, no matter the destination, packets are always >> + * sent to the single peer listening on the other side >> + */ >> + rcu_read_lock(); >> + match = (peer == rcu_dereference(ovpn->peer)); >> + rcu_read_unlock(); > > Here you are not dereferencing ovpn->peer, so you can use > rcu_access_pointer() instead and avoid the rcu_read_lock/unlock() pair. I see - thanks for pointing this out! Will switch to rcu_access_pointer(). Regards, -- Antonio Quartulli OpenVPN Inc.