From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CBB42EEA0; Tue, 5 May 2026 12:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777984537; cv=none; b=WMlFlYjzP0lneO00EgXuCKbttbTkz9kC4+wPxypK++apDZ/3DWB3zGHfmgxdFjgqKWl7SB+JsTFJCXTlUZAjhsn2TYJl+FDltUl4e3Tt66BQ4wJ5kk9a/DL/NcsfKN5H6GXiw4xy+7Gcn7ZqyxN5R+8wlX75A7l3YEF8o8hqFQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777984537; c=relaxed/simple; bh=ewAipKl9czmlOyqZkct/sLi9ASWai8T9gsDFcP7L+Is=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U6Mxi9rduNGXy45s5wvHaFHVcEKVfK0O4HixJCIQgRYacIDLpAWOTay4+ie+XJMSKVX2sXsAHGaj9Y9wWh4IeRqHwVBWfDC8EKqJZusGSknqB18yxfwP8EvbBLtI5PmGjartsVCZoG125urPgalCPt8f2BQH8KGLfIf5OOfAJHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=HmamxsEv; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="HmamxsEv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9U5AzifTMcaLV7XnmUa5PNSNmCETirlJ7ajoajXH6nY=; b=HmamxsEvU/oHCE40EPW/Fo9w+X DT3av6mtcXI4fpGwXLuFWiZxH6u2ZcoiqXgSUyyUgjS73aWS/1MTzZWH55VEHeLSfz70UUNAooUVA g2pnP8EAANxm+9vewFAeDL++RBa2rFCLSOA4wG8AJoCFb1tzXPpjUbDHoJQlPqIxmlVI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wKEzn-001SQV-J7; Tue, 05 May 2026 14:35:27 +0200 Date: Tue, 5 May 2026 14:35:27 +0200 From: Andrew Lunn To: Shitalkumar Gandhi Cc: Niklas =?iso-8859-1?Q?S=F6derlund?= , Geert Uytterhoeven , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: Re: [PATCH net v2] net: rtsn: fix mdio_node leak in rtsn_mdio_alloc() Message-ID: <94576888-2906-4dfa-8d45-a7f0e9ef712b@lunn.ch> References: <20260505123236.406000-1-shitalkumar.gandhi@cambiumnetworks.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505123236.406000-1-shitalkumar.gandhi@cambiumnetworks.com> On Tue, May 05, 2026 at 06:02:36PM +0530, Shitalkumar Gandhi wrote: > of_get_child_by_name() takes a reference. The rtsn_reset() and > rtsn_change_mode() failure paths jump to out_free_bus and leak > mdio_node. > > Add out_put_node to drop it before falling through. > > Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") > Signed-off-by: Shitalkumar Gandhi > Reviewed-by: Geert Uytterhoeven Reviewed-by: Andrew Lunn Andrew