From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Ilya Maximets <i.maximets@ovn.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
"Remy D. Farley" <one-d-wide@protonmail.com>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
stable@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] netlink: specs: fix the conntrack filter type
Date: Wed, 26 Aug 2026 17:20:47 +0000 [thread overview]
Message-ID: <94842eea-a296-4ab9-a026-2475757a82b8@fiberby.net> (raw)
In-Reply-To: <20260825155832.3685714-1-i.maximets@ovn.org>
On 8/25/26 3:58 PM, Ilya Maximets wrote:
> The CTA_FILTER doesn't contain nested tuple attributes, instead it
> contains bit masks that specify which tuple attributes to filter on.
> The values for filtering are taken from the top-level CTA_TUPLE_ORIG
> and CTA_TUPLE_REPLY.
As identified by Sashiko-NIPA[1], then CTA_TUPLE_ORIG and CTA_TUPLE_REPLY
are both absent from the GET DUMP request attribute list.
However this doesn't prevent ynl CLI from sending the attributes:
$ sudo ./tools/net/ynl/pyynl/cli.py --family conntrack --dump get --json \
'{"nfgen-family": 2, "filter": {"orig-flags": 1}}'
Netlink error: Invalid argument
$ sudo ./tools/net/ynl/pyynl/cli.py --family conntrack --dump get --json \
'{"nfgen-family": 2, "filter": {"orig-flags": 1}, "tuple-orig": {"tuple-ip": {"ip-v4-src": "192.255.0.255", "ip-v4-dst":
"192.255.255.0"}}}'
[]
Otherwise, LGTM.
[1] https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260825155832.3685714-1-i.maximets%40ovn.org
next prev parent reply other threads:[~2026-08-26 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 15:58 [PATCH net] netlink: specs: fix the conntrack filter type Ilya Maximets
2026-08-26 17:20 ` Asbjørn Sloth Tønnesen [this message]
2026-08-26 18:38 ` Ilya Maximets
2026-08-26 19:40 ` Asbjørn Sloth Tønnesen
2026-08-26 20:24 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94842eea-a296-4ab9-a026-2475757a82b8@fiberby.net \
--to=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=one-d-wide@protonmail.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox