From: Eduard Zingerman <eddyz87@gmail.com>
To: Amery Hung <ameryhung@gmail.com>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
andrii@kernel.org, daniel@iogearbox.net, memxor@gmail.com,
martin.lau@kernel.org, mykyta.yatsenko5@gmail.com,
kernel-team@meta.com
Subject: Re: [PATCH bpf-next v5 07/14] bpf: Unify referenced object tracking in verifier
Date: Wed, 20 May 2026 15:28:56 -0700 [thread overview]
Message-ID: <94954f57c4130610ca740f04b49941d04ee498da.camel@gmail.com> (raw)
In-Reply-To: <20260519181314.2731658-8-ameryhung@gmail.com>
On Tue, 2026-05-19 at 11:13 -0700, Amery Hung wrote:
> Helpers and kfuncs independently tracked referenced object metadata (id,
> ref_obj_id) using separate fields in their respective arg_meta structs.
> This led to duplicated logic and inconsistent error handling between the
> two paths.
>
> Introduce struct ref_obj_desc to consolidate these fields along with a
> count of how many arguments carry a reference. Add update_ref_obj() to
> populate it from a bpf_reg_state, replacing open-coded assignments in
> check_func_arg(), check_kfunc_args(), and process_iter_arg(). Add
> validate_ref_obj() to check for ambiguous ref_obj before using it.
>
> For ref_obj releasing helpers and kfuncs, keep checking it before
> calling update_ref_obj() for now. A later patch will make these
> functions not depending on ref_obj. For other users of ref_obj, move the
> checks to the use locations. For helper, this means moving the checks
> inside helper_multiple_ref_obj_use() to use locations.
> is_acquire_function() is dropped as ref_obj is never used.
>
> Pass ref_obj_desc into process_dynptr_func()/mark_stack_slots_dynptr()
> instead of a bare parent_id to make it less confusing.
>
> Drop the selftest introduced in 7ec899ac90a2 (“selftests/bpf: Negative
> test case for ref_obj_id in args”) since the verifier no longer
> complains about ambiguous ref_obj if it is not used.
>
> Signed-off-by: Amery Hung <ameryhung@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2026-05-20 22:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 18:12 [PATCH bpf-next v5 00/14] Refactor verifier object relationship tracking Amery Hung
2026-05-19 18:12 ` [PATCH bpf-next v5 01/14] bpf: Simplify mark_stack_slot_obj_read() and callers Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 02/14] bpf: Unify dynptr handling in the verifier Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 03/14] bpf: Assign reg->id when getting referenced kptr from ctx Amery Hung
2026-05-19 18:56 ` bot+bpf-ci
2026-05-19 20:17 ` Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 04/14] bpf: Preserve reg->id of pointer objects after null-check Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 05/14] bpf: Refactor object relationship tracking and fix dynptr UAF bug Amery Hung
2026-05-20 21:47 ` Eduard Zingerman
2026-05-21 7:18 ` Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 06/14] bpf: Remove redundant dynptr arg check for helper Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 07/14] bpf: Unify referenced object tracking in verifier Amery Hung
2026-05-20 22:28 ` Eduard Zingerman [this message]
2026-05-19 18:13 ` [PATCH bpf-next v5 08/14] bpf: Unify release handling for helpers and kfuncs Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 09/14] bpf: Fold ref_obj_id into id and introduce virtual references Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 10/14] bpf: Fix dynptr ref counting to scan all call frames Amery Hung
2026-05-20 19:59 ` Eduard Zingerman
2026-05-20 22:41 ` Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 11/14] selftests/bpf: Test creating dynptr from dynptr data and slice Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 12/14] selftests/bpf: Test using dynptr after freeing the underlying object Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 13/14] selftests/bpf: Test using slice after invalidating dynptr clone Amery Hung
2026-05-19 18:13 ` [PATCH bpf-next v5 14/14] selftests/bpf: Test using file dynptr after the reference on file is dropped Amery Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94954f57c4130610ca740f04b49941d04ee498da.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox