netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Alex Henrie <alexhenrie24@gmail.com>,
	netdev@vger.kernel.org, dan@danm.net, bagasdotme@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, jikos@kernel.org
Subject: Re: [PATCH net-next 2/3] net: ipv6/addrconf: introduce a regen_min_advance sysctl
Date: Tue, 13 Feb 2024 08:36:13 -0700	[thread overview]
Message-ID: <94aad0b2-142e-40eb-b81f-c98457bd1b58@kernel.org> (raw)
In-Reply-To: <20240209061035.3757-2-alexhenrie24@gmail.com>

On 2/8/24 11:10 PM, Alex Henrie wrote:
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 7afff42612e9..fcd6aa71b4fa 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2535,6 +2535,14 @@ max_desync_factor - INTEGER
>  
>  	Default: 600
>  
> +regen_min_advance - INTEGER
> +	How far in advance (in seconds), at minimum, to create a new temporary
> +	address before the current one is deprecated. This value is added to
> +	the amount of time that may be required for duplicate address detection
> +	to detemine when to create a new address.

s/detemine/determine/

Add some more comments here - e.g., RFC 8981 recommends a minimum of no
less than 2 seconds which is the default.

> +
> +	Default: 2
> +
>  regen_max_retry - INTEGER
>  	Number of attempts before give up attempting to generate
>  	valid temporary addresses.



  reply	other threads:[~2024-02-13 15:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  6:10 [PATCH net-next 1/3] net: ipv6/addrconf: ensure that regen_advance is at least 2 seconds Alex Henrie
2024-02-09  6:10 ` [PATCH net-next 2/3] net: ipv6/addrconf: introduce a regen_min_advance sysctl Alex Henrie
2024-02-13 15:36   ` David Ahern [this message]
2024-02-09  6:10 ` [PATCH net-next 3/3] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2024-02-13 10:13   ` Paolo Abeni
2024-02-13 15:40     ` David Ahern
2024-02-13 21:07       ` Dan Moulding
2024-02-13 15:35 ` [PATCH net-next 1/3] net: ipv6/addrconf: ensure that regen_advance is at least 2 seconds David Ahern
2024-02-14  6:26 ` [PATCH net-next v2 0/3] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are long enough Alex Henrie
2024-02-14  6:26   ` [PATCH net-next v2 1/3] net: ipv6/addrconf: ensure that regen_advance is at least 2 seconds Alex Henrie
2024-02-14 15:38     ` David Ahern
2024-02-14  6:26   ` [PATCH net-next v2 2/3] net: ipv6/addrconf: introduce a regen_min_advance sysctl Alex Henrie
2024-02-14 15:39     ` David Ahern
2024-02-14  6:26   ` [PATCH net-next v2 3/3] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2024-02-14 15:40     ` David Ahern
2024-02-15 14:50   ` [PATCH net-next v2 0/3] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are long enough patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94aad0b2-142e-40eb-b81f-c98457bd1b58@kernel.org \
    --to=dsahern@kernel.org \
    --cc=alexhenrie24@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=dan@danm.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jikos@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).