From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 2/8] json: add %hhu helpers
Date: Tue, 20 Nov 2018 16:18:20 -0700 [thread overview]
Message-ID: <94ab531a-27f4-8bc5-ed3e-f792d9b8da6d@gmail.com> (raw)
In-Reply-To: <20181119174018.0629445a@cakuba.netronome.com>
On 11/19/18 6:40 PM, Jakub Kicinski wrote:
> On Mon, 19 Nov 2018 17:18:42 -0800, Stephen Hemminger wrote:
>>> void jsonw_hu_field(json_writer_t *self, const char *prop, unsigned short num)
>>> {
>>> jsonw_name(self, prop);
>>
>> Do you really need this? it turns out that because of C type
>> conversions print_uint should just work?
>
> I wondered about that for a second, but I took the existence of
> jsonw_hu_field() etc. as a proof that explicit typing is preferred.
>
Stephen: you ok with the explicit typing version?
next prev parent reply other threads:[~2018-11-21 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 23:03 [PATCH iproute2-next 0/8] tc: gred: JSON-ify and support per-vq config Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 1/8] tc: gred: remove unclear comment Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 2/8] json: add %hhu helpers Jakub Kicinski
2018-11-20 1:18 ` Stephen Hemminger
2018-11-20 1:40 ` Jakub Kicinski
2018-11-20 23:18 ` David Ahern [this message]
2018-11-19 23:03 ` [PATCH iproute2-next 3/8] tc: move RED flag printing to helper Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 4/8] tc: gred: jsonify GRED output Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 5/8] tc: gred: separate out stats printing Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 6/8] tc: gred: use extended stats if available Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 7/8] tc: gred: support controlling RED flags Jakub Kicinski
2018-11-19 23:03 ` [PATCH iproute2-next 8/8] tc: gred: allow controlling and dumping per-DP " Jakub Kicinski
2018-11-24 15:26 ` [PATCH iproute2-next 0/8] tc: gred: JSON-ify and support per-vq config David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94ab531a-27f4-8bc5-ed3e-f792d9b8da6d@gmail.com \
--to=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).