From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bhadram Varka Subject: Re: STMMAC driver with TSO enabled issue Date: Fri, 25 May 2018 19:55:09 +0530 Message-ID: <94cda7c4-127c-cae1-e51e-8853224065e2@nvidia.com> References: <89c0a735-9e34-89c6-7692-579e48dadaa6@nvidia.com> <77c98a42-195f-b597-711d-8c2e8b55f266@synopsys.com> <5309d046-fc6f-bc63-06dc-6cc98276dce4@nvidia.com> <77ff3baf-fec5-f0a2-9fdf-caa63d4944d0@synopsys.com> <06ec3e2e-c41a-5f19-ffd8-51c5453d586b@synopsys.com> <3143ce1f-30e7-6b8d-06b5-6048abab54bc@nvidia.com> <78914761-0375-5929-ed88-5225e0e260b9@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT To: Jose Abreu , "netdev@vger.kernel.org" , Joao Pinto Return-path: Received: from hqemgate14.nvidia.com ([216.228.121.143]:11217 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935949AbeEYOZP (ORCPT ); Fri, 25 May 2018 10:25:15 -0400 In-Reply-To: <78914761-0375-5929-ed88-5225e0e260b9@synopsys.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: > Hi Bhadram, > > On 25-05-2018 05:41, Bhadram Varka wrote: >> Hi Jose, >> >> On 5/24/2018 3:01 PM, Jose Abreu wrote: >>> Hi Bhadram, >>> >>> On 24-05-2018 06:58, Bhadram Varka wrote: >>>> >>>> After some time if check Tx descriptor status - then I see only >>>> below >>>> >>>> [..] >>>> [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 >>>> 0x90000000 >>>> >>>> index 025 and 026 descriptors processed but not index 027. >>>> >>>> At this stage Tx DMA is always in below state - >>>> >>>> ■ 3'b011: Running (Reading Data from system memory >>>> buffer and queuing it to the Tx buffer (Tx FIFO)) >>> >>> Thats strange, I think the descriptors look okay though. I will >>> need the registers values (before the lock) and, if possible, the >>> git bisect output. >> >> Attaching the register dump file after the issue observed. >> Please check once. >> > > ----->8----- > 0x112c = 0x0000003F > 0x11ac = 0x0000003F > 0x122c = 0x0000003F > 0x12ac = 0x0000003F > > 0x1130 = 0x0000003F > 0x11b0 = 0x0000003F > 0x1230 = 0x0000003F > 0x12b0 = 0x0000003F > ----->8----- > > This can't be right, it should be DMA_{RX/TX}_SIZE - 1 = 511. Did > you change these values in the code? > Yes. I have changed the descriptor length to 64 - so that searching for the current descriptor status would be easy. -- Thanks, Bhadram.