From: "Arinzon, David" <darinzon@amazon.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Allen, Neil" <shayagr@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Andrew Lunn <andrew@lunn.ch>, Leon Romanovsky <leon@kernel.org>,
Jiri Pirko <jiri@resnulli.us>
Subject: RE: [PATCH v12 net-next 9/9] net: ena: Add PHC documentation
Date: Tue, 17 Jun 2025 09:50:56 +0000 [thread overview]
Message-ID: <94f10b5cac8f497ba168ea360461bd3e@amazon.com> (raw)
In-Reply-To: <20250616173200.103a5654@kernel.org>
> > +- ``CONFIG_PTP_1588_CLOCK=m``: the PTP module needs to be loaded
> prior to loading the ENA driver:
> > +
> > +Load PTP module:
> > +
> > +.. code-block:: shell
> > +
> > + sudo modprobe ptp
>
> Again, I'm not sure that's true. If user insmods the ena driver and PTP=m
> then sure, PTP needs to be loaded. But modprobe would load it
> automatically. So this appears to be an echo of out-of-tree docs.
I see your point and agree, thanks for noticing.
Will make the change in the documentation in v13.
prev parent reply other threads:[~2025-06-17 9:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 9:22 [PATCH v12 net-next 0/9] PHC support in ENA driver David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 1/9] net: ena: Add PHC support in the " David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 2/9] net: ena: PHC silent reset David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 3/9] net: ena: Add device reload capability through devlink David Arinzon
2025-06-17 0:27 ` Jakub Kicinski
2025-06-17 7:17 ` Arinzon, David
2025-06-11 9:22 ` [PATCH v12 net-next 4/9] net: ena: Add devlink port support David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 5/9] devlink: Add new "enable_phc" generic device param David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 6/9] net: ena: Control PHC enable through devlink David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 7/9] net: ena: Add debugfs support to the ENA driver David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 8/9] net: ena: View PHC stats using debugfs David Arinzon
2025-06-11 9:22 ` [PATCH v12 net-next 9/9] net: ena: Add PHC documentation David Arinzon
2025-06-17 0:32 ` Jakub Kicinski
2025-06-17 9:50 ` Arinzon, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f10b5cac8f497ba168ea360461bd3e@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew@lunn.ch \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=vadim.fedorenko@linux.dev \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).