From: Andrew Lunn <andrew@lunn.ch>
To: Frank Sae <Frank.Sae@motor-comm.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xiaogang.fan@motor-comm.com,
fei.zhang@motor-comm.com, hua.sun@motor-comm.com
Subject: Re: [RFC] net:yt6801: Add Motorcomm yt6801 PCIe driver
Date: Fri, 13 Sep 2024 19:02:44 +0200 [thread overview]
Message-ID: <9506d808-85b9-4f37-baee-76f3dee56182@lunn.ch> (raw)
In-Reply-To: <20240913124113.9174-1-Frank.Sae@motor-comm.com>
On Fri, Sep 13, 2024 at 09:00:04PM +0800, Frank Sae wrote:
> This patch is to add the ethernet device driver for the PCIe interface of
> Motorcomm YT6801 Gigabit Ethernet.
One 11,927 line patch?
Please look at how other Ethernet drivers are submitted. Please break
this up. You should also look at the comments other drivers get when
submitted. A quick look through suggests there is plenty of broken
stuff in here which has been commented on before. You should not be
repeating the errors of others.
FYI: All your PHY handling code needs throwing away and use phylink or
phylib.
Andrew
next prev parent reply other threads:[~2024-09-13 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:00 [RFC] net:yt6801: Add Motorcomm yt6801 PCIe driver Frank Sae
2024-09-13 17:02 ` Andrew Lunn [this message]
2024-09-20 23:05 ` Bjorn Helgaas
2024-09-20 23:22 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9506d808-85b9-4f37-baee-76f3dee56182@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.zhang@motor-comm.com \
--cc=hua.sun@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaogang.fan@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox