From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2-next v10] Add support for CAKE qdisc
Date: Thu, 19 Jul 2018 09:22:09 -0600
Message-ID: <951130c0-7eb9-19a0-e418-04f8263ab97c@gmail.com>
References: <20180716163926.4826-1-toke@toke.dk>
 <ecadada4-3a27-f11c-dc8d-00998cf1d097@gmail.com> <87bmb34htz.fsf@toke.dk>
 <a5ed73bd-b093-1fb9-a106-ae0b82efb7ff@gmail.com> <87r2jz2qxi.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f194.google.com ([209.85.215.194]:43602 "EHLO
        mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731105AbeGSQFv (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Jul 2018 12:05:51 -0400
Received: by mail-pg1-f194.google.com with SMTP id v13-v6so4062560pgr.10
        for <netdev@vger.kernel.org>; Thu, 19 Jul 2018 08:22:12 -0700 (PDT)
In-Reply-To: <87r2jz2qxi.fsf@toke.dk>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/19/18 9:20 AM, Toke Høiland-Jørgensen wrote:
> David Ahern <dsahern@gmail.com> writes:
> 
>> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote:
>>> A few comments below; will fix the rest.
>>>
>>>>> +			print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth);
>>>>> +			print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth, b1));
>>>>> +		} else
>>>>> +			print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited");
>>>>> +	}
>>>>> +	if (tb[TCA_CAKE_AUTORATE] &&
>>>>> +		RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) {
>>>>> +		autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]);
>>>>> +		if(autorate == 1)
>>>>> +			print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress");
>>
>> This just caught me eye as well ... why the '_' after autorate?
> 
> Well, the parameter is called autorate_ingress to make it a single
> token. When adding JSON support I picked the key/value representation
> mostly because we could theoretically add other autorate modes in the
> future (the netlink parameter allows it).

ok, just seems odd that json and stdout representations are different.