From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09406C169C4 for ; Thu, 7 Feb 2019 01:48:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C51002081B for ; Thu, 7 Feb 2019 01:48:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VQFUrPex" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbfBGBs1 (ORCPT ); Wed, 6 Feb 2019 20:48:27 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:54940 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfBGBs1 (ORCPT ); Wed, 6 Feb 2019 20:48:27 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x171dtDP181242; Thu, 7 Feb 2019 01:48:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=nMryZk2UW64nAMHhr5s0N5pwKTNBLt0ZGBjWh5v8W9M=; b=VQFUrPexT6syzEvTTcfLhM0j2OM5xvpKVrvN3giKusAF5Ho8RKoJr8Ir5ycPTbdMVnCx Y2o9pa948AizfK43iVjKvmFv+2y7uWi3SJZlg/q9miGvm/jq9rcKUnoqEngVmEGSawgj +BHR3iVa0FUwIsUmVEMrvSoAJMN0N/DBe8NmKq6f51Duy52MJoP9+HQJ3cLlGVkS1Rnc mRMS6kWKjoEuTmya8EHNbclZC4jQx2TYo9K/H4GNkFKpVIRIEpnUY1q3R6Z7aoQn/p/u nBxFPosgycvFpvcmb5RQCYOhg3Y8E4aziWYv9J5I0NpysaYRoRYnHOHAXrY9LCaN0MXo pw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2qd97f4ctf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Feb 2019 01:48:20 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x171mEwZ012823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Feb 2019 01:48:14 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x171mDG3026286; Thu, 7 Feb 2019 01:48:13 GMT Received: from [10.182.69.170] (/10.182.69.170) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 07 Feb 2019 01:48:12 +0000 Subject: Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles To: Yang Wei , netdev@vger.kernel.org Cc: davem@davemloft.net, shannon.nelson@oracle.com, robh@kernel.org, yang.wei9@zte.com.cn References: <1549383584-5605-1-git-send-email-albin_yang@163.com> From: Yanjun Zhu Organization: Oracle Corporation Message-ID: <951b48c4-2c9b-a2cf-b00f-d29c9f7a0f3e@oracle.com> Date: Thu, 7 Feb 2019 09:51:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <1549383584-5605-1-git-send-email-albin_yang@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9159 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902070010 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/2/6 0:19, Yang Wei wrote: > From: Yang Wei > > dev_consume_skb_irq() should be called when skb xmit done. It makes > drop profiles(dropwatch, perf) more friendly. Thanks a lot. I am OK. Zhu Yanjun > > Signed-off-by: Yang Wei > --- > drivers/net/ethernet/sun/cassini.c | 2 +- > drivers/net/ethernet/sun/sunbmac.c | 2 +- > drivers/net/ethernet/sun/sunhme.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c > index 7ec4eb7..6fc05c1 100644 > --- a/drivers/net/ethernet/sun/cassini.c > +++ b/drivers/net/ethernet/sun/cassini.c > @@ -1898,7 +1898,7 @@ static inline void cas_tx_ringN(struct cas *cp, int ring, int limit) > cp->net_stats[ring].tx_packets++; > cp->net_stats[ring].tx_bytes += skb->len; > spin_unlock(&cp->stat_lock[ring]); > - dev_kfree_skb_irq(skb); > + dev_consume_skb_irq(skb); > } > cp->tx_old[ring] = entry; > > diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c > index 720b7ac..e9b757b 100644 > --- a/drivers/net/ethernet/sun/sunbmac.c > +++ b/drivers/net/ethernet/sun/sunbmac.c > @@ -781,7 +781,7 @@ static void bigmac_tx(struct bigmac *bp) > > DTX(("skb(%p) ", skb)); > bp->tx_skbs[elem] = NULL; > - dev_kfree_skb_irq(skb); > + dev_consume_skb_irq(skb); > > elem = NEXT_TX(elem); > } > diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c > index ff641cf..d007dfe 100644 > --- a/drivers/net/ethernet/sun/sunhme.c > +++ b/drivers/net/ethernet/sun/sunhme.c > @@ -1962,7 +1962,7 @@ static void happy_meal_tx(struct happy_meal *hp) > this = &txbase[elem]; > } > > - dev_kfree_skb_irq(skb); > + dev_consume_skb_irq(skb); > dev->stats.tx_packets++; > } > hp->tx_old = elem;