* [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
@ 2019-02-05 16:19 Yang Wei
2019-02-07 1:43 ` David Miller
2019-02-07 1:51 ` Yanjun Zhu
0 siblings, 2 replies; 3+ messages in thread
From: Yang Wei @ 2019-02-05 16:19 UTC (permalink / raw)
To: netdev; +Cc: davem, yanjun.zhu, shannon.nelson, robh, yang.wei9, albin_yang
From: Yang Wei <yang.wei9@zte.com.cn>
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
drivers/net/ethernet/sun/cassini.c | 2 +-
drivers/net/ethernet/sun/sunbmac.c | 2 +-
drivers/net/ethernet/sun/sunhme.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index 7ec4eb7..6fc05c1 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -1898,7 +1898,7 @@ static inline void cas_tx_ringN(struct cas *cp, int ring, int limit)
cp->net_stats[ring].tx_packets++;
cp->net_stats[ring].tx_bytes += skb->len;
spin_unlock(&cp->stat_lock[ring]);
- dev_kfree_skb_irq(skb);
+ dev_consume_skb_irq(skb);
}
cp->tx_old[ring] = entry;
diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c
index 720b7ac..e9b757b 100644
--- a/drivers/net/ethernet/sun/sunbmac.c
+++ b/drivers/net/ethernet/sun/sunbmac.c
@@ -781,7 +781,7 @@ static void bigmac_tx(struct bigmac *bp)
DTX(("skb(%p) ", skb));
bp->tx_skbs[elem] = NULL;
- dev_kfree_skb_irq(skb);
+ dev_consume_skb_irq(skb);
elem = NEXT_TX(elem);
}
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index ff641cf..d007dfe 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -1962,7 +1962,7 @@ static void happy_meal_tx(struct happy_meal *hp)
this = &txbase[elem];
}
- dev_kfree_skb_irq(skb);
+ dev_consume_skb_irq(skb);
dev->stats.tx_packets++;
}
hp->tx_old = elem;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-05 16:19 [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
@ 2019-02-07 1:43 ` David Miller
2019-02-07 1:51 ` Yanjun Zhu
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-07 1:43 UTC (permalink / raw)
To: albin_yang; +Cc: netdev, yanjun.zhu, shannon.nelson, robh, yang.wei9
From: Yang Wei <albin_yang@163.com>
Date: Wed, 6 Feb 2019 00:19:44 +0800
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called when skb xmit done. It makes
> drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-05 16:19 [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-07 1:43 ` David Miller
@ 2019-02-07 1:51 ` Yanjun Zhu
1 sibling, 0 replies; 3+ messages in thread
From: Yanjun Zhu @ 2019-02-07 1:51 UTC (permalink / raw)
To: Yang Wei, netdev; +Cc: davem, shannon.nelson, robh, yang.wei9
On 2019/2/6 0:19, Yang Wei wrote:
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called when skb xmit done. It makes
> drop profiles(dropwatch, perf) more friendly.
Thanks a lot. I am OK.
Zhu Yanjun
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
> ---
> drivers/net/ethernet/sun/cassini.c | 2 +-
> drivers/net/ethernet/sun/sunbmac.c | 2 +-
> drivers/net/ethernet/sun/sunhme.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
> index 7ec4eb7..6fc05c1 100644
> --- a/drivers/net/ethernet/sun/cassini.c
> +++ b/drivers/net/ethernet/sun/cassini.c
> @@ -1898,7 +1898,7 @@ static inline void cas_tx_ringN(struct cas *cp, int ring, int limit)
> cp->net_stats[ring].tx_packets++;
> cp->net_stats[ring].tx_bytes += skb->len;
> spin_unlock(&cp->stat_lock[ring]);
> - dev_kfree_skb_irq(skb);
> + dev_consume_skb_irq(skb);
> }
> cp->tx_old[ring] = entry;
>
> diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c
> index 720b7ac..e9b757b 100644
> --- a/drivers/net/ethernet/sun/sunbmac.c
> +++ b/drivers/net/ethernet/sun/sunbmac.c
> @@ -781,7 +781,7 @@ static void bigmac_tx(struct bigmac *bp)
>
> DTX(("skb(%p) ", skb));
> bp->tx_skbs[elem] = NULL;
> - dev_kfree_skb_irq(skb);
> + dev_consume_skb_irq(skb);
>
> elem = NEXT_TX(elem);
> }
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index ff641cf..d007dfe 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1962,7 +1962,7 @@ static void happy_meal_tx(struct happy_meal *hp)
> this = &txbase[elem];
> }
>
> - dev_kfree_skb_irq(skb);
> + dev_consume_skb_irq(skb);
> dev->stats.tx_packets++;
> }
> hp->tx_old = elem;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-07 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05 16:19 [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-07 1:43 ` David Miller
2019-02-07 1:51 ` Yanjun Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).