From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] net: phy: harmonize phy_id{,_mask} data type Date: Tue, 21 Nov 2017 09:48:17 -0800 Message-ID: <9525d5e5-a26e-79b8-dfc3-8f7d73250fd6@gmail.com> References: <20171121095256.25507-1-dev@g0hl1n.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richard.leitner@skidata.com To: Richard Leitner , andrew@lunn.ch Return-path: In-Reply-To: <20171121095256.25507-1-dev@g0hl1n.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/21/2017 01:52 AM, Richard Leitner wrote: > From: Richard Leitner > > Previously phy_id was u32 and phy_id_mask was unsigned int. As the > phy_id_mask defines the important bits of the phy_id (and is therefore > the same size) these two variables should be the same data type. > > Signed-off-by: Richard Leitner Reviewed-by: Florian Fainelli Thanks! > --- > This patch is extracted from the "net: ethernet: fec: fix refclk enable for SMSC LAN8710/20" > patch series. This was done because this series will be reworked and > rebased on not yet merged feature later on. For more details see: > https://patchwork.ozlabs.org/cover/839468/ > --- > include/linux/phy.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index dc82a07cb4fd..e00fd9ce3bce 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -509,7 +509,7 @@ struct phy_driver { > struct mdio_driver_common mdiodrv; > u32 phy_id; > char *name; > - unsigned int phy_id_mask; > + u32 phy_id_mask; > u32 features; > u32 flags; > const void *driver_data; > -- Florian