public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Shalom Toledo <shalomt@mellanox.com>
To: Ido Schimmel <idosch@idosch.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer
Date: Mon, 16 Sep 2019 08:14:47 +0000	[thread overview]
Message-ID: <95297977-0757-68c2-77f3-960056050fb3@mellanox.com> (raw)
In-Reply-To: <20190916061750.26207-1-idosch@idosch.org>

Hi David,

I have v3 with all the fixes Jiri commented. Can I send it? Or should I wait
until net-next will be open again?

Thanks,
Shalom.

On 16/09/2019 9:17, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@mellanox.com>
> 
> Shalom says:
> 
> While debugging packet loss towards the CPU, it is useful to be able to
> query the CPU port's shared buffer quotas and occupancy.
> 
> Patch #1 prevents changing the CPU port's threshold and binding.
> 
> Patch #2 registers the CPU port with devlink.
> 
> Patch #3 adds the ability to query the CPU port's shared buffer quotas and
> occupancy.
> 
> v2:
> 
> Patch #1:
> * s/0/MLXSW_PORT_CPU_PORT/
> * Assign "mlxsw_sp->ports[MLXSW_PORT_CPU_PORT" at the end of
>   mlxsw_sp_cpu_port_create() to avoid NULL assignment on error path
> * Add common functions for mlxsw_core_port_init/fini()
> 
> Patch #2:
> * Move "changing CPU port's threshold and binding" check to a separate
>   patch
> 
> Shalom Toledo (3):
>   mlxsw: spectrum_buffers: Prevent changing CPU port's configuration
>   mlxsw: spectrum: Register CPU port with devlink
>   mlxsw: spectrum_buffers: Add the ability to query the CPU port's
>     shared buffer
> 
>  drivers/net/ethernet/mellanox/mlxsw/core.c    | 65 ++++++++++++++++---
>  drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 ++
>  .../net/ethernet/mellanox/mlxsw/spectrum.c    | 46 +++++++++++++
>  .../mellanox/mlxsw/spectrum_buffers.c         | 51 ++++++++++++---
>  4 files changed, 150 insertions(+), 17 deletions(-)
> 


  parent reply	other threads:[~2019-09-16  8:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16  6:17 [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer Ido Schimmel
2019-09-16  6:17 ` [PATCH net-next v2 1/3] mlxsw: spectrum_buffers: Prevent changing CPU port's configuration Ido Schimmel
2019-09-16  7:00   ` Jiri Pirko
2019-09-16  6:17 ` [PATCH net-next v2 2/3] mlxsw: spectrum: Register CPU port with devlink Ido Schimmel
2019-09-16  7:08   ` Jiri Pirko
2019-09-16  6:17 ` [PATCH net-next v2 3/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer Ido Schimmel
2019-09-16  8:00   ` Jiri Pirko
2019-09-16  8:14 ` Shalom Toledo [this message]
2019-09-16 13:59   ` [PATCH net-next v2 0/3] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95297977-0757-68c2-77f3-960056050fb3@mellanox.com \
    --to=shalomt@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=idosch@idosch.org \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox