From: Martin KaFai Lau <martin.lau@linux.dev>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Eyal Birger <eyal.birger@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
herbert@gondor.apana.org.au, andrii@kernel.org,
daniel@iogearbox.net, nicolas.dichtel@6wind.com,
razor@blackwall.org, mykolal@fb.com, ast@kernel.org,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, shuah@kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH ipsec-next 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF
Date: Wed, 30 Nov 2022 11:10:13 -0800 [thread overview]
Message-ID: <953fb82c-0871-748e-e0f0-6ecca6ec80ee@linux.dev> (raw)
In-Reply-To: <20221129081510.56b1025e@kernel.org>
On 11/29/22 8:15 AM, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 10:50:01 +0100 Steffen Klassert wrote:
>>> Please tag for bpf-next
>>
>> This is a change to xfrm ipsec, so it should go
>> through the ipsec-next tree, unless there is
>> a good reason for handling that different.
The set is mostly depending on the bpf features. Patch 2 is mostly depending on
bpf and patch 3 is also a bpf selftest. I assume the set should have been
developed based on the bpf-next tree instead. It is also good to have the test
run in bpf CI sooner than later to bar on-going bpf changes that may break it.
It is the reason I think bpf-next makes more sense.
If it is preferred to go through ipsec-next, the set should at least be tested
against the bpf-next before posting.
https://patchwork.kernel.org/project/netdevbpf/patch/20221129132018.985887-4-eyal.birger@gmail.com/
next prev parent reply other threads:[~2022-11-30 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 16:04 [PATCH ipsec-next 0/3] xfrm: interface: Add unstable helpers for XFRM metadata Eyal Birger
2022-11-28 16:04 ` [PATCH ipsec-next 1/3] xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c Eyal Birger
2022-11-28 16:05 ` [PATCH ipsec-next 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF Eyal Birger
2022-11-29 1:58 ` Martin KaFai Lau
2022-11-29 8:36 ` Eyal Birger
2022-11-29 9:50 ` Steffen Klassert
2022-11-29 16:15 ` Jakub Kicinski
2022-11-30 8:39 ` Steffen Klassert
2022-11-30 19:10 ` Martin KaFai Lau [this message]
2022-12-01 7:12 ` Steffen Klassert
2022-11-28 16:05 ` [PATCH ipsec-next 3/3] selftests/bpf: add xfrm_info tests Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953fb82c-0871-748e-e0f0-6ecca6ec80ee@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=haoluo@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).