Re: [PATCH V2 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock

[Jon Hunter <jonathanh@nvidia.com>]

On 25/03/2026 06:18, Jon Hunter wrote:
> 
> On 24/03/2026 22:57, Rob Herring (Arm) wrote:
>>
>> On Tue, 24 Mar 2026 12:16:30 +0000, Jon Hunter wrote:
>>> The PTP clock for the Tegra234 MGBE device is incorrectly named
>>> 'ptp-ref' and should be 'ptp_ref'. This is causing the following
>>> warning to be observed on Tegra234 platforms that use this device:
>>>
>>>   ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate
>>>   WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed
>>>
>>> Although this constitutes an ABI breakage in the binding for this
>>> device, PTP support has clearly never worked and so fix this now
>>> so we can correct the device-tree for this device. Note that the
>>> MGBE driver still supports the legacy 'ptp-ref' clock name and so
>>> older/existing device-trees will still work, but given that this
>>> is not the correct name, there is no point to advertise this in the
>>> binding.
>>>
>>> Fixes: 189c2e5c7669 ("dt-bindings: net: Add Tegra234 MGBE")
>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>> ---
>>>   Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/ 
>> bindings/net/nvidia,tegra234-mgbe.example.dtb: ethernet@6800000 
>> (nvidia,tegra234-mgbe): clock-names:3: 'ptp_ref' was expected
>>     from schema $id: http://devicetree.org/schemas/net/ 
>> nvidia,tegra234-mgbe.yaml
> 
> Yes this is expected until patch 3/3 is applied.

Well apparently somehow I managed to miss the example. I will fix that now.

Jon

-- 
nvpublic