Re: [PATCH v9 net-next 5/5] selftest/net: psp: Add test for dev-assoc/disassoc

[Daniel Zahka <daniel.zahka@gmail.com>]

On 3/30/26 6:31 PM, Wei Wang wrote:
> +
> +def _dev_assoc_no_nsid(cfg):
> +    """ Test dev-assoc and dev-disassoc without nsid attribute """
> +    _init_psp_dev(cfg, True)
> +    psp_dev_id = cfg.psp_dev_id
> +
> +    # Get nk_host's ifindex (in host namespace, same as caller)
> +    nk_host_dev = ip(f"link show dev {cfg._nk_host_ifname}", json=True)[0]
> +    nk_host_ifindex = nk_host_dev['ifindex']
> +
> +    # Associate without nsid - should look up ifindex in caller's netns
> +    cfg.pspnl.dev_assoc({'id': psp_dev_id, 'ifindex': nk_host_ifindex})
> +
> +    # Verify assoc-list contains the device
> +    dev_info = cfg.pspnl.dev_get({'id': psp_dev_id})
> +    ksft_true('assoc-list' in dev_info, "No assoc-list after association")
> +    found = False
> +    for assoc in dev_info['assoc-list']:
> +        if assoc['ifindex'] == nk_host_ifindex:
> +            found = True
> +            break
> +    ksft_true(found, "Associated device not found in assoc-list")
> +
> +    # Disassociate without nsid - should also use caller's netns
> +    cfg.pspnl.dev_disassoc({'id': psp_dev_id, 'ifindex': nk_host_ifindex})
> +
> +    # Verify assoc-list no longer contains the device
> +    dev_info = cfg.pspnl.dev_get({'id': psp_dev_id})
> +    found = False
> +    if 'assoc-list' in dev_info:
> +        for assoc in dev_info['assoc-list']:
> +            if assoc['ifindex'] == nk_host_ifindex:
> +                found = True
> +                break
> +    ksft_true(not found, "Device should not be in assoc-list after disassociation")
> +
> +    del cfg.psp_dev_id
> +    del cfg.psp_info
> +
...
> +
> +@ksft_variants([
> +    KsftNamedVariant(f"v{v}_ip6", v, "6")
> +    for v in range(4)
> +])
> +def dev_assoc_no_nsid(cfg, version, ipver):
> +    cfg.require_ipver(ipver)
> +    _dev_assoc_no_nsid(cfg)
> +


Why do we need ip connectivity for this test? Why are you parameterizing 
over PSP version?