From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384333ABD91 for ; Sat, 11 Jul 2026 10:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783765292; cv=none; b=PlSM9UYuSFTO8at5wCV8i7QrmikpwpOHYOc111GqRI8H/JLhjYyjqIKjg7IkKeDRmG7b45zjR7ZV78bjPcD/D7notY4Vi5t5IUk2xLe0kbDiwVsIKVvS7N8cwl2FBZ2k5WmKY/T3c/Uo1YA9OaTFy5M6HjsX0QxEiAxHAuoveKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783765292; c=relaxed/simple; bh=UQB/hpyjg0fkQEqF4vmD7lOhkY9VP7eUZBHDfc2wfb4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GoXO9gSYFnjkiLAWE6SBST4NO7uq3zpVwstOt8BiVOSJ+qdkfn69l3Kke6ybTt/iAonsOTekgJtbKKozot7L1/TCyJ/U7Pfsw7fLNOmgD5YCt8Q5ucN7Ft9G2ItD6B89y5sYFeMx0k4BlXnksGCjeFWNZYc9rbN2zDhSJK0xFTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BgKBgmA2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jUO1/yDs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BgKBgmA2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jUO1/yDs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783765287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FqOWMNobt5ZaR1dGNykes+ERauAl9+tAeFvEcMLSsq0=; b=BgKBgmA2WbWJUeoyaiU06rX1uh2LHUEib4Io9FIKLyypP5dP30D8nnUvW1bcXWhRpA/cFU qr2RJ8qSwuTnBm6RCjeTu8jiGLak6/9NdnxSWC34WQ497y3lZlhHW0pAMlhpg15xjIyNhg 0Xxjedak+OPQEW543UP6Ex6DogK0PJg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-y_X_bVQIMtCySbnOVVcuig-1; Sat, 11 Jul 2026 06:21:25 -0400 X-MC-Unique: y_X_bVQIMtCySbnOVVcuig-1 X-Mimecast-MFC-AGG-ID: y_X_bVQIMtCySbnOVVcuig_1783765285 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493b54823bdso13627185e9.0 for ; Sat, 11 Jul 2026 03:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783765284; x=1784370084; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FqOWMNobt5ZaR1dGNykes+ERauAl9+tAeFvEcMLSsq0=; b=jUO1/yDshoFqfPHwo/YQE+nLCAX/fFpAHuJS8Qb0Jv9kjyDaZbW6w5LGm8nIcu5+3o uK9+KxjCiC+sGYtzWIGzft8WfGGOzpx2X7ZBbYI6A7wgk+YuNmeAcAO2y+4aYUZZjQjV LHE2f416L4Uku8gw1MxSOeWfYJDG7JNogzBi43tro7MT1nQJOKLcKuW9fgR3ObVVGV22 MbwFF0XhTULpHhxJcDFC3CbTiMUmCnuaUtkdl2tO4FLDSmQrc90inLFRsrP2oHHuaOPT 2xAAKiTK+mKxrSgR0P8kfI9K9L7qPb1Vw1/EKHtTMW6UOzq9LeRtn0ZUEIxJPNBioM1U iMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783765284; x=1784370084; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FqOWMNobt5ZaR1dGNykes+ERauAl9+tAeFvEcMLSsq0=; b=k6hGLps4Ga2P9FdPsx82J/JOwS2zHE5YUyu7YmHGvA//bcCChev4bcAgXmmRyHVORD WrXTb+IPma6V4ZdeoEXluT53ArpQuTYXRtgBMhYiOR9/4BLIY92dUb/lqKB6nNcT1XnM 7Wn6gZKsKKNtwo+qrqabn88FiRKQyNAGZzuVOj8RJttzur8OU4YDFZheewq/gYvByCkU Zif0ZmTt2eFojUwRAKbFB+hPzXn5szfmjOuBU8wLa8vEwMCCVIw20NVXhfUOwAbmW5KK H58EOiD/hmNvpmtK/UHaBYn9bvt3EOOVsH1xFejV8zXeluuvCx8/O3yNSE6HcwZu9558 xAsA== X-Forwarded-Encrypted: i=1; AHgh+RqZ/bv9KJk0wmOXSrs3s6KaDA/okZ+0fA0Bl++71wyoq9Omv7VJ6hxKG5lAFQWPG4h5TSG5ins=@vger.kernel.org X-Gm-Message-State: AOJu0YySdTVWhTaEG/IR45RpjYMrhcm72qSM0ceH2wxre+amoMXEHIZt v/N+e/UwENLudvwpCPCrzlcAHAqpskDX+7TYNrvTBEXOZDY4MbeuQtAH8hUFEtdtnu6ci9dBpyp R0UqHuXE3TpIy0JF1AGM08IhYkYptSK9pu5ltPGvN/vH3CWYypVC0m4VWPQ== X-Gm-Gg: AfdE7cnLPx5lg04b2dVHCKyGqdbFiPXl78T/F6Emi4kKzcAHLbVvpZoTjT17cezwCyE CRSCBEyrmxV3Atn6+wz7P1c4V9hqpZnlBpEAmTfM9qTUpuAZoRNN/j/myHcnzmM50OcUrvD7esG RecXNJJV/kCZmwae9j3WdaKytucUK4+cgrJB2GByU4MK8gV8d1dV+MSyKFo8Gisz028L8WXYiAt 4Fv90h3X/uu3ut2nXHZH/FPtnYkPxEum+uXJwFoL9N8lsKx7tQoE/5voqK+p+W7VCKQr5EE09sO c9DeDm7Y0KL9CB57qlbjY7tPUCZuhxvrWelEeWcnmQQme8zyx9Bb13uR0gMfgAvcVA/QxXfkJYF Yi/cy+jACF80xD2hQhuhac+4aF7/4VdosLeqQF4lCk9U2urQ2/VoW/Fxo/0guZZtwTwoc9BZVn0 My/TLs X-Received: by 2002:a05:600c:1391:b0:493:d117:18a8 with SMTP id 5b1f17b1804b1-493f88bd849mr23242685e9.9.1783765284605; Sat, 11 Jul 2026 03:21:24 -0700 (PDT) X-Received: by 2002:a05:600c:1391:b0:493:d117:18a8 with SMTP id 5b1f17b1804b1-493f88bd849mr23242515e9.9.1783765284207; Sat, 11 Jul 2026 03:21:24 -0700 (PDT) Received: from [192.168.0.115] (ip90-44-231-195.pool-bba.aruba.it. [195.231.44.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f49755f9sm116063285e9.8.2026.07.11.03.21.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 03:21:23 -0700 (PDT) Message-ID: <9576dd12-9b68-443c-be53-486516bdf801@redhat.com> Date: Sat, 11 Jul 2026 12:21:22 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net-next 13/14] ipvlan: Protect ipvl_port.ipvlans with mutex. To: Kuniyuki Iwashima Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Andrew Lunn , Simon Horman , Kuniyuki Iwashima , netdev@vger.kernel.org References: <20260703001009.1572444-1-kuniyu@google.com> <20260703001009.1572444-14-kuniyu@google.com> <71f1aba1-78b6-4e7b-8dc9-092b50402e07@redhat.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/10/26 6:15 PM, Kuniyuki Iwashima wrote: > On Fri, Jul 10, 2026 at 4:08 AM Paolo Abeni wrote: >> On 7/3/26 2:09 AM, Kuniyuki Iwashima wrote: >>> @@ -800,9 +831,15 @@ static int ipvlan_device_event(struct notifier_block *unused, >>> if (dev->reg_state != NETREG_UNREGISTERING) >>> break; >>> >>> - list_for_each_entry_safe(ipvlan, next, &port->ipvlans, pnode) >>> - ipvlan->dev->rtnl_link_ops->dellink(ipvlan->dev, >>> - &lst_kill); >>> + list_for_each_entry_safe(ipvlan, next, &port->ipvlans, pnode) { >>> +#if IS_ENABLED(CONFIG_IPVTAP) >>> + if (ipvlan->dev->rtnl_link_ops != &ipvlan_link_ops) >>> + __ipvtap_dellink_ptr(ipvlan->dev, &lst_kill); >>> + else >>> +#endif >>> + __ipvlan_link_delete(ipvlan->dev, &lst_kill); >> >> I'm not sure if it's worthy a repost, but what about adding a >> link_delete_unlocked() cb to `struct ipvl_dev *`? IMHO should make this >> code more straight forward. > > Since port is allocated in ndo_init(), ipvtap needs to wrap it > and overwrite port->ops everytime for one time (or at ->newlink), > but I don't have strong opinion here. > > It would be nicer if I could follow up since this series gets 5-days > penalty on Suie due to too many Sashiko false-positive, get_net(), > and a build warning due to xchg() for veth, and we will likely lose > context next week :) FTR, I'm not strictly following Suie order - it's more a mix of Suie, FIFO and common sense. What impact most in series processing is the sheer amount of patches in PW vs avail time. /P