Re: [PATCH net-next 02/15] idpf: add module register and probe functionality

[Jesse Brandeburg <jesse.brandeburg@intel.com>]

On 5/30/2023 11:05 PM, Michael S. Tsirkin wrote:
> On Tue, May 30, 2023 at 04:44:48PM -0700, Tony Nguyen wrote:
>> From: Phani Burra <phani.r.burra@intel.com>
...

>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c b/drivers/net/ethernet/intel/idpf/idpf_main.c
>> new file mode 100644
>> index 000000000000..e290f560ce14
>> --- /dev/null
>> +++ b/drivers/net/ethernet/intel/idpf/idpf_main.c
>> @@ -0,0 +1,136 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/* Copyright (C) 2023 Intel Corporation */
>> +
>> +#include "idpf.h"
>> +#include "idpf_devids.h"
>> +
>> +#define DRV_SUMMARY	"Infrastructure Data Path Function Linux Driver"
> 
> Do you want to stick Intel(R) here as well?

That would be ok with me, we'll discuss internally.

> And did you say you wanted to add a version?

In-kernel drivers use the kernel version for the MODULE_VERSION field.

> The point being making it possible to distinguish
> between this one and the one we'll hopefully have down
> the road binding to the IDPF class/prog ifc.
> 
>> +
>> +MODULE_DESCRIPTION(DRV_SUMMARY);
>> +MODULE_LICENSE("GPL");
Just noticed that we appear to have missed the MODULE_AUTHOR("Intel
Corporation")