From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net v3] net/ipv6: Add anycast addresses to a global
 hashtable
Date: Fri, 26 Oct 2018 15:44:32 -0600
Message-ID: <95cb5670-eaf0-c7af-7e35-bc4f6e68c5ba@gmail.com>
References: <CAL6e_pdbk9+5g-6dr54f9aT4v1RHV_thxM+zb4w41J0n_ydNcA@mail.gmail.com>
 <20181026212242.9661-1-0xeffeff@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
To: Jeff Barnhill <0xeffeff@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f194.google.com ([209.85.215.194]:37562 "EHLO
        mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728018AbeJ0GXP (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 27 Oct 2018 02:23:15 -0400
Received: by mail-pg1-f194.google.com with SMTP id c10-v6so1124319pgq.4
        for <netdev@vger.kernel.org>; Fri, 26 Oct 2018 14:44:35 -0700 (PDT)
In-Reply-To: <20181026212242.9661-1-0xeffeff@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/26/18 3:22 PM, Jeff Barnhill wrote:
> @@ -275,6 +356,13 @@ int __ipv6_dev_ac_inc(struct inet6_dev *idev, const struct in6_addr *addr)
>  		err = -ENOMEM;
>  		goto out;
>  	}
> +	err = ipv6_add_acaddr_hash(dev_net(idev->dev), addr);
> +	if (err) {
> +		fib6_info_release(f6i);
> +		fib6_info_release(f6i);
> +		kfree(aca);
> +		goto out;
> +	}

I think aca_put() makes this less confusing as it will do the
fib6_info_release(f6i) and kfree(aca);