From: Hayes Wang <hayeswang@realtek.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function
Date: Wed, 26 Jul 2023 09:50:01 +0000 [thread overview]
Message-ID: <95ecef91f1b9446f8a69280d69422b40@realtek.com> (raw)
In-Reply-To: <c63b0f24-4e6b-4df3-8783-9899d178b16e@lunn.ch>
Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, July 26, 2023 4:37 PM
[...]
> How often is byte_en 0xff? Do you have some benchmark numbers to show
> it is worth the complexity?
It is usually used for writing firmware.
The firmware contains several blocks of continuous registers.
I think it is worth, even this only saves several numbers of control transfer.
This patch could replace 3 control transfers with 1 control transfer.
If you could do it with one step, why do you use 3 steps?
Besides, a control transfer is a complex process.
I think this could reduce the loading of both software and hardware.
Best Regards,
Hayes
next prev parent reply other threads:[~2023-07-26 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 3:08 [PATCH net-next v2 0/2] r8152: reduce control transfer Hayes Wang
2023-07-26 3:08 ` [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function Hayes Wang
2023-07-26 8:36 ` Andrew Lunn
2023-07-26 9:50 ` Hayes Wang [this message]
2023-07-26 3:08 ` [PATCH net-next v2 2/2] r8152: set bp in bulk Hayes Wang
2023-07-26 8:39 ` Andrew Lunn
2023-07-26 9:50 ` Hayes Wang
2023-07-29 1:10 ` [PATCH net-next v2 0/2] r8152: reduce control transfer patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95ecef91f1b9446f8a69280d69422b40@realtek.com \
--to=hayeswang@realtek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).