From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF1AC433F5 for ; Wed, 15 Sep 2021 17:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00202611CA for ; Wed, 15 Sep 2021 17:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhIORcV (ORCPT ); Wed, 15 Sep 2021 13:32:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhIORcT (ORCPT ); Wed, 15 Sep 2021 13:32:19 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D161FC061575 for ; Wed, 15 Sep 2021 10:31:00 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id k12-20020a056830150c00b0051abe7f680bso4597001otp.1 for ; Wed, 15 Sep 2021 10:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9JtSIbr8G39fqSliHS6q346bx9+Drp/ZRZGEdlrX5yg=; b=GbNX139aCTTV7q/EVehaF7UU7QdI7WLXuN4pwhOFr6BUX8YuWAFZmdb7mcPEeFUnaU P6A3IXzU5K5pT5J1AyqBdAjrlN0s+tShQnSFZ+ZE64LIkWsLLXNJVJvLrGn9f27J2skV p9qqYc29xpg+z/DpUWijMY0QdBg7uxbzxqfx//9H9/AVzpT3hnGNDggXiJAZIT7lnH4o eRy6RRCa8z7AoPprlt4SCsnqf7o/wLTMemxSBuqK2WlFLA5wIp+ANbXIK01I8cCCFNh5 sTo8OFnjkGoBISFefTotdwfdPAGYuPM7unydr7gaX4bdr0gKYHRe5IDtGxjH/97QO0iE yvVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9JtSIbr8G39fqSliHS6q346bx9+Drp/ZRZGEdlrX5yg=; b=Gr6W9q9s0Yrt29CxraV1NN7gA11qdlZnYd6WB/JfXgPun5kBacHJeijmDNjVnCpP2z W2JTxQgeO0oArQHeaG11bG0kr181SCZTdGShMO/heWvsQ3sd83rOFWyDi3tPlnWZ7e/9 nx22zN9jIfrtXg5eWxmdzFM/s91BRDSGdVPJo9gzYwiyKgfPB7NXe2NRmwXzS2gLaVjw 6SolvuT7YQL3tCGuSHjOJLhiXzu4fBqkdnolF8xNf9cQ0rgX22iIDD8fbstj/N+8Fw+b cJRz7YfPavgHtcDN+0koya8SZ6yExobmQyxc7vOzd1SdJLhaTqVTlrJES4pWyph40W6P SObQ== X-Gm-Message-State: AOAM531JBOXBoOPvggrkCuyubTP5jXVfTGC9cwHoktkQwirMlkcmy1JG eDaU37uWpK/btXxTdePDXSAc78MDAOstHqm7 X-Google-Smtp-Source: ABdhPJyybl96d96E1YJHLGsl7h94gTxKp+WUCDfKCD5T8bcBTBJO7CuSZZCOdA+L/uTq5xudWSVTVw== X-Received: by 2002:a9d:6c19:: with SMTP id f25mr1044713otq.192.1631727060195; Wed, 15 Sep 2021 10:31:00 -0700 (PDT) Received: from MacBook-Pro.hackershack.net (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id u194sm167808oie.37.2021.09.15.10.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 10:30:59 -0700 (PDT) Subject: Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter To: Dan Carpenter , Yassine Oudjana Cc: bjorn.andersson@linaro.org, butterflyhuangxx@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-arm-msm@vger.kernel.org, loic.poulain@linaro.org, mani@kernel.org, netdev@vger.kernel.org References: <20210906065320.GC1935@kadam> From: Steev Klimaszewski Message-ID: <95ee6b7d-a51d-71bb-1245-501740357839@kali.org> Date: Wed, 15 Sep 2021 12:30:57 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210906065320.GC1935@kadam> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/6/21 1:53 AM, Dan Carpenter wrote: > On Fri, Sep 03, 2021 at 07:29:28PM +0000, Yassine Oudjana wrote: >> > if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA && >> > @@ -506,8 +506,12 @@ int qrtr_endpoint_post(struct qrtr_endpoint >> *ep, const void *data, size_t len) >> > >> > if (cb->type == QRTR_TYPE_NEW_SERVER) { >> > /* Remote node endpoint can bridge other distant nodes */ >> > - const struct qrtr_ctrl_pkt *pkt = data + hdrlen; >> > + const struct qrtr_ctrl_pkt *pkt; >> > >> > + if (size < sizeof(*pkt)) >> > + goto err; >> > + >> > + pkt = data + hdrlen; >> > qrtr_node_assign(node, le32_to_cpu(pkt->server.node)); >> > } >> > >> > -- >> > 2.20.1 >> > >> >> This is crashing MSM8996. I get these messages (dmesg | grep >> remoteproc): > Yes. I apologize for that. The fix has been merged already. > > regards, > dan carpenter Where has the fix been merged to?  5.14.4 released with this patch in it, and wifi is now crashing on the Lenovo Yoga C630 with the same messages that Yassine was seeing.