From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3 net-next] net: mdio: mscc-miim: Remove some redundant code
Date: Fri, 15 May 2026 17:45:24 +0200 [thread overview]
Message-ID: <9616afb9-a506-4d5a-94ca-269e78fb6a0e@bootlin.com> (raw)
In-Reply-To: <11209c6c6485656cc9a841c495381c540783798a.1778856199.git.christophe.jaillet@wanadoo.fr>
Hi,
On 5/15/26 16:50, Christophe JAILLET wrote:
> *pbus is assign twice with the same value. Remove one of the redundant
> assignment.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> drivers/net/mdio/mdio-mscc-miim.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
> index 259944d37fbd..03878bd9091d 100644
> --- a/drivers/net/mdio/mdio-mscc-miim.c
> +++ b/drivers/net/mdio/mdio-mscc-miim.c
> @@ -233,8 +233,6 @@ int mscc_miim_setup(struct device *dev, struct mii_bus **pbus, const char *name,
>
> miim = bus->priv;
>
> - *pbus = bus;
> -
> miim->regs = mii_regmap;
> miim->mii_status_offset = status_offset;
> miim->ignore_read_errors = ignore_read_errors;
next prev parent reply other threads:[~2026-05-15 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 14:50 [PATCH 0/3] net: phy: micrel: Code clean-up Christophe JAILLET
2026-05-15 14:50 ` [PATCH 1/3 net-next] net: mdio: mscc-miim: Remove some redundant code Christophe JAILLET
2026-05-15 15:45 ` Maxime Chevallier [this message]
2026-05-15 14:50 ` [PATCH 2/3 net-next] net: mdio: mscc-miim: Use devm_clk_get_optional_enabled() Christophe JAILLET
2026-05-15 15:53 ` Maxime Chevallier
2026-05-15 14:50 ` [PATCH 3/3 net-next] net: mdio: mscc-miim: Use devm_of_mdiobus_register() Christophe JAILLET
2026-05-15 15:54 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9616afb9-a506-4d5a-94ca-269e78fb6a0e@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox