netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jerry Ray <jerry.ray@microchip.com>, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] dsa: lan9303: Correct stat name
Date: Mon, 28 Nov 2022 12:04:22 -0800	[thread overview]
Message-ID: <9619489a-1325-4124-d2c8-3dddab1fc625@gmail.com> (raw)
In-Reply-To: <20221128193559.6572-1-jerry.ray@microchip.com>

On 11/28/22 11:35, Jerry Ray wrote:
> Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

The Fixes: tag is supposed to come above your Signed-off-by, I don't 
know if the maintainers will fix that up manually or not, but in any case:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> 
> This patch changes the reported ethtool statistics for the lan9303
> family of parts covered by this driver.
> 
> The TxUnderRun statistic label is renamed to RxShort to accurately
> reflect what stat the device is reporting.  I did not reorder the
> statistics as that might cause problems with existing user code that
> are expecting the stats at a certain offset.
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> ---
>   drivers/net/dsa/lan9303-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> index 438e46af03e9..80f07bd20593 100644
> --- a/drivers/net/dsa/lan9303-core.c
> +++ b/drivers/net/dsa/lan9303-core.c
> @@ -961,7 +961,7 @@ static const struct lan9303_mib_desc lan9303_mib[] = {
>   	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
>   	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
>   	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
> -	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
> +	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
>   	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
>   	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
>   	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },

-- 
Florian


  reply	other threads:[~2022-11-28 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 19:35 [net PATCH] dsa: lan9303: Correct stat name Jerry Ray
2022-11-28 20:04 ` Florian Fainelli [this message]
2022-11-29  2:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9619489a-1325-4124-d2c8-3dddab1fc625@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jerry.ray@microchip.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).