From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903AD15958A for ; Wed, 29 May 2024 14:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716993268; cv=none; b=uhFKo0jApJhpjdPJFxeEQpi7BiRpbrO8cz0eRXbOYIkdS2KYFJiiBPhKIyswKyIr/NxofqiBkytfKlPHK/erkbQbCsCvYkWFeziF1xPVbGDYZECPQ/QfUYxHnHdc2nZoxcLmn1I/m8b4qlFcGIhDL7lXW1bidgJis/B56Z7O2f4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716993268; c=relaxed/simple; bh=+gUBYjF+Y8hwJU4yqDNq/idF/ljkT845h8jbGF6pDyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cw9DpkYM3zNttl8CiAj6qmfv5OsSpC3sGUwWp2ZRJQQawbtt/qIe/xsIgn4X+DjXGB/UJFe4XKPllCAguPWp0vxSewYvz2PV/RcrRpRqidqXLSUwh/AxC2AP2YAboac8NNLKqukKRConpQjxyDHR9LVcsnHA1ZEvGS59KNB36Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y9fG5jcp; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y9fG5jcp" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a621cb07d8fso244013366b.2 for ; Wed, 29 May 2024 07:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716993265; x=1717598065; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UxKvozPEtwlO8OXnPN6yBQ22rv1LshJRA3Kmq/ptkTs=; b=Y9fG5jcpRMiFeI4D4vKZnQLkP5WZk0NRWI0YbhKG//899/NHkGeUnFOJt/UM0Ztw0U tqkFHL+InqbDNOyRsV2ljzq3bcb2kggGJID6rv2U9b4ZpxtgNijrjCgVuW8Xv+q2Cq8C 3JEiLGET8TfdT2N/Lnw95Bai0/0egOdEQ1M07+opoTz1vQSlWSSk2crwXIFmAbokEu81 s2u99yMMVnzIS1U77ZiMxamOjbS/4CzaKpb+0H1UAgrteGMJXrMt/2QEOd44ZNHa6DG1 0NW8tXB36YodCGLb4wQVkFAZ31PimVFWN0cgQifV0FmJmrU/3QcZSSe+A3zo5KrMU6B5 ejUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716993265; x=1717598065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UxKvozPEtwlO8OXnPN6yBQ22rv1LshJRA3Kmq/ptkTs=; b=MWBPjR0x6J0fKy+7N/VpBYV7v1vOKLGClA4XDIw/9jpp0rM00nl9KM9kc11aSyl+D2 51oSqSjvfcqT/51IIEiQVNHmwCnLcQUPKfmcR1rWGDyMoiLhHRwXLAgxwYdzqjcalMbg eMO3aIxdXqQGnO4FKQEui+K18hJjznZ3Y8H/bHZ5nd2P/wwTl+kivlg8rZz/nj8v3h0S ExetcVGyXBm2d4pT77UU90pA1Xu+uHM8UngT+DRhEYVgQfmGMrgTfv+rkKg2UUdeUvCS LmZ/Htvf/nTwya58W2bIb7pWhkpIsHzRSZUD7jl+T1XwPVPDbp2GATZaV4MJi1Mfn/WA FCIw== X-Forwarded-Encrypted: i=1; AJvYcCW6ZBhYhGaLFlqMqQAlu0fioxIFVYcmt6tkz3mP9TyRq0P9c/BG7XWc6E6VW7rjknQ1L4X/vbqNlcdOcollZZ33LvLBVGVi X-Gm-Message-State: AOJu0YxWJ44X+ZrpkhsoQMMwg2ImVkzWa/txV3Lm2to/epfEZOAU1lwZ UuPdeOY1+zZiw4TFoaBL/cu4XsNs93fxzA8jAUMXc448c7j2idxvy/MgmN2Rfb8= X-Google-Smtp-Source: AGHT+IG4+VOpbeCI0VHpQAmsZbgQumjd4HqVZdvwzgiyKtu4frzTjhK3ZWfHPP3/Uv4v5N7256hwMw== X-Received: by 2002:a17:906:391a:b0:a59:a83b:d438 with SMTP id a640c23a62f3a-a62641b9ae6mr1027059966b.23.1716993264720; Wed, 29 May 2024 07:34:24 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8adf3sm723121666b.152.2024.05.29.07.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 07:34:24 -0700 (PDT) Date: Wed, 29 May 2024 17:34:20 +0300 From: Dan Carpenter To: Lars Kellogg-Stedman Cc: Paolo Abeni , linux-hams@vger.kernel.org, netdev@vger.kernel.org, Duoming Zhou Subject: Re: [PATCH v4] ax25: Fix refcount imbalance on inbound connections Message-ID: <962afcda-8f67-400f-b3eb-951bf2e46fb7@moroto.mountain> References: <20240522183133.729159-2-lars@oddbit.com> <8e9a1c59f78a7774268bb6defed46df6f3771cbc.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Sorry for the delay on sending this. My email daemon messed up so all my outgoing mail has been going to /dev/null for the past few days. Resending everything... -dan ] On Tue, May 28, 2024 at 12:06:39PM -0400, Lars Kellogg-Stedman wrote: > On Tue, May 28, 2024 at 11:40:38AM GMT, Paolo Abeni wrote: > > Note that the fixes tag above is still wrong - the hash must be 12 > > chars long, see: > > I had spotted that, thanks. Just waiting to see if there are any real > change requests before re-submitting. Okay. It looks good to me. Sorry for all the headache. 1) The Fixes tag points to the wrong commit, though, right? The one you have here doesn't make sense and it doesn't match the bisect. 2) Can we edit the commitmessage a bit to say include what you wrote about "but rather bind/accept" being paired. We increment in bind and we should increment in accept as well. It's the same. 3) The other thing that I notice is that Duoming dropped part of his commit when he resent v6. https://lore.kernel.org/all/5c61fea1b20f3c1596e4fb46282c3dedc54513a3.1715065005.git.duoming@zju.edu.cn/ That part of the commit was correct. Maybe it wasn't necessary but it feels right and it's more readable and it's obviously harmless. I can resend that. regards, dan carpenter