From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Vosburgh Subject: Re: [PATCH next v6 3/5] bonding: Allow userspace to set actors' system_priority in AD system Date: Thu, 19 Feb 2015 13:39:22 -0800 Message-ID: <9642.1424381962@famine> References: <1424328621-14245-1-git-send-email-maheshb@google.com> Cc: Andy Gospodarek , Veaceslav Falico , Nikolay Aleksandrov , David Miller , Maciej Zenczykowski , netdev , Eric Dumazet To: Mahesh Bandewar Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:41486 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbbBSVj3 (ORCPT ); Thu, 19 Feb 2015 16:39:29 -0500 In-reply-to: <1424328621-14245-1-git-send-email-maheshb@google.com> Sender: netdev-owner@vger.kernel.org List-ID: [ Sorry, I hadn't read v6 earlier; resending for the current version so it is filed properly in patchwork... ] Mahesh Bandewar wrote: >This patch allows user to randomize the system-priority in an ad-system. >The allowed range is 1 - 0xFFFF while default value is 0xFFFF. If user >does not specify this value, the system defaults to 0xFFFF, which is >what it was before this patch. > >Following example code could set the value - > # modprobe bonding mode=4 > # sys_prio=$(( 1 + RANDOM + RANDOM )) > # echo $sys_prio > /sys/class/net/bond0/bonding/ad_actor_sys_prio > # echo +eth1 > /sys/class/net/bond0/bonding/slaves > ... > # ip link set bond0 up > >Signed-off-by: Mahesh Bandewar >Reviewed-by: Nikolay Aleksandrov Mahesh: Andy and I got together at netdev01 and discussed the patches of this series that add options to sysfs for bonding (patches 3, 4, and 5). In summary, in my opinion a netlink / iproute2 interface needs to be provided simultaneously with any new sysfs interface for bonding. I realize that the sysfs api to bonding won't go away, but nevertheless users should be encouraged to use netlink preferentially. Providing the api pieces together encourages this. As it happens, Andy mentioned that he has patches similar to these three, but with the netlink portion already implemented. My suggestion here is therefore for Andy to post his patches, and then we can merge these together, and get this implemented properly with a minimum of duplicated effort. -J --- -Jay Vosburgh, jay.vosburgh@canonical.com