From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=XBjt=QA=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ED765C282C3
	for <netdev@archiver.kernel.org>; Thu, 24 Jan 2019 11:24:50 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BC93E21872
	for <netdev@archiver.kernel.org>; Thu, 24 Jan 2019 11:24:50 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727722AbfAXLYt (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 24 Jan 2019 06:24:49 -0500
Received: from www62.your-server.de ([213.133.104.62]:46484 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726053AbfAXLYt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 24 Jan 2019 06:24:49 -0500
Received: from [78.46.172.3] (helo=sslproxy06.your-server.de)
        by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89_1)
        (envelope-from <daniel@iogearbox.net>)
        id 1gmd7k-00025d-Hp; Thu, 24 Jan 2019 12:24:44 +0100
Received: from [178.197.249.22] (helo=linux.home)
        by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89)
        (envelope-from <daniel@iogearbox.net>)
        id 1gmd7k-000NTV-CH; Thu, 24 Jan 2019 12:24:44 +0100
Subject: Re: [PATCH v2 bpf-next] bpf: use the proper optlen when doing strncpy
 in bpf_getsockopt()
To:     Yafang Shao <laoar.shao@gmail.com>, kafai@fb.com, brakmo@fb.com,
        ast@kernel.org
Cc:     netdev@vger.kernel.org, shaoyafang@didiglobal.com
References: <1548306994-877-1-git-send-email-laoar.shao@gmail.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <9645e625-e090-2fa4-b570-0862ddfc5b19@iogearbox.net>
Date:   Thu, 24 Jan 2019 12:24:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1548306994-877-1-git-send-email-laoar.shao@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: daniel@iogearbox.net
X-Virus-Scanned: Clear (ClamAV 0.100.2/25326/Thu Jan 24 03:30:43 2019)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On 01/24/2019 06:16 AM, Yafang Shao wrote:
> As strncpy(..., TCP_CA_NAME_MAX-1) is used in bpf_setsockopt(),
> this change  will make it more consistent with the bpf_setsockopt() above.
> 
> Acked-by: Martin KaFai Lau <kafai@fb.com>
> Acked-by: Lawrence Brakmo <brakmo@fb.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

While not wrong, I also don't think it improves much either. As mentioned,
that code is totally fine as it currently is.