From: David Ahern <dsahern@kernel.org>
To: Justin Iurman <justin.iurman@uliege.be>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next v2 1/2] ip: lwtunnel: tunsrc support
Date: Wed, 28 Aug 2024 15:22:10 -0700 [thread overview]
Message-ID: <9654009f-5ea8-433e-a4ba-28602f8bb61a@kernel.org> (raw)
In-Reply-To: <e8420765-dec6-4802-8255-89f9f6965c59@uliege.be>
On 8/27/24 1:41 AM, Justin Iurman wrote:
> On 8/26/24 17:59, Stephen Hemminger wrote:
>> On Mon, 26 Aug 2024 15:52:28 +0200
>> Justin Iurman <justin.iurman@uliege.be> wrote:
>>
>>> - if (mode != IOAM6_IPTUNNEL_MODE_INLINE)
>>> + if (mode != IOAM6_IPTUNNEL_MODE_INLINE) {
>>> + if (tb[IOAM6_IPTUNNEL_SRC]) {
>>> + print_string(PRINT_ANY, "tunsrc", "tunsrc %s ",
>>> + rt_addr_n2a_rta(AF_INET6,
>>> + tb[IOAM6_IPTUNNEL_SRC]));
>>> + }
>>> +
>>> print_string(PRINT_ANY, "tundst", "tundst %s ",
>>> rt_addr_n2a_rta(AF_INET6, tb[IOAM6_IPTUNNEL_DST]));
>>> + }
>>
>> Looks good.
>> These strings should be printed with
>> print_color_string(PRINT_ANY, COLOR_INET6, ...
>>
>> but that is not urgent. Just to follow convention.
>
> Ack, thanks! I can submit -v3 now to include the change though. WDYT?
sure. send an update now. I most likely will not have time to update the
headers and commit until this weekend.
next prev parent reply other threads:[~2024-08-28 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 13:52 [PATCH iproute2-next v2 0/2] add support for tunsrc Justin Iurman
2024-08-26 13:52 ` [PATCH iproute2-next v2 1/2] ip: lwtunnel: tunsrc support Justin Iurman
2024-08-26 15:59 ` Stephen Hemminger
2024-08-27 7:41 ` Justin Iurman
2024-08-28 22:22 ` David Ahern [this message]
2024-08-26 13:52 ` [PATCH iproute2-next v2 2/2] man8: ip-route: update documentation Justin Iurman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9654009f-5ea8-433e-a4ba-28602f8bb61a@kernel.org \
--to=dsahern@kernel.org \
--cc=justin.iurman@uliege.be \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox