From: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Re: [PATCH net-next-2.6 1/2] mq: support for bonding
Date: Sun, 28 Feb 2010 11:25:13 +0300 [thread overview]
Message-ID: <96591267345513@webmail87.yandex.ru> (raw)
In-Reply-To: <1267288154.9082.23.camel@edumazet-laptop>
Hi Eric,
27.02.10, 17:29, "Eric Dumazet" <eric.dumazet@gmail.com>:
> My dev machine has 16 cpus, and my network card has 16 queues per NIC
We should borrow this number from real device when enslaving it, picking
maximum value from among slaves. But the main problem is that we don't
known anything about slaves in bond_create() and there is no way to change
number of tx queues later. Maybe we could solve this by adding new module
parameter for bonding (num_tx_queues)?
> Every xmit has to get this lock(s) and performance is not optimal.
You're right. I don't notice it. I see two solutions:
1) Convert all rw_locks to RCU mechanism
2) Use plain array instead of linked list to store list of slaves. In this case we
don't need to lock when doing bond_for_each_slave().
.. Or am I wrong? What do you think?
--
wbr, Oleg.
next prev parent reply other threads:[~2010-02-28 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 13:27 [PATCH net-next-2.6 1/2] mq: support for bonding "Oleg A. Arkhangelsky"
2010-02-27 16:29 ` Eric Dumazet
2010-02-28 8:25 ` "Oleg A. Arkhangelsky" [this message]
2010-02-28 9:05 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96591267345513@webmail87.yandex.ru \
--to=sysoleg@yandex.ru \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).