From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
"Robert Elliott" <elliott@hpe.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH iwl-net v1] ice: fix bug with suspend and rebuild
Date: Wed, 6 Mar 2024 17:41:10 -0800 [thread overview]
Message-ID: <9662b26f-3bba-41fb-90a6-3a6dbf98b5f5@intel.com> (raw)
In-Reply-To: <02751cec-c273-4120-adad-6ea16a86532b@intel.com>
On 3/6/2024 5:33 PM, Jesse Brandeburg wrote:
> On 3/6/2024 8:56 AM, Maciej Fijalkowski wrote:
>>>> Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
>>>> Reported-by: Robert Elliott <elliott@hpe.com>
>>>> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>>
>>> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>>>
>>> Well, that refactor of config path introduced lots of issues. Could
>>> validation folks include a short list of tests they tried out against
>>> tested patch?
That's a good question which I'll follow up on with our team, but please
don't let it block anything for this patch.
>>
>> Sorry, I got confused and now I saw the same thing Simon pointed out.
>
> Thanks, NP! this thread is for v1, and v2 is already posted with the
> refactor just moving the CONFIG_FOO in patch 1, and then the real final
> version of the fix in v2 patch two which switches all the intel drivers
> over to the new macros.
oops!
FYI v2 of this change was posted at
https://lore.kernel.org/netdev/20240305230204.448724-1-jesse.brandeburg@intel.com/
Thanks for the review!
next prev parent reply other threads:[~2024-03-07 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 23:08 [PATCH iwl-net v1] ice: fix bug with suspend and rebuild Jesse Brandeburg
2024-03-05 6:28 ` [Intel-wired-lan] " Paul Menzel
2024-03-05 13:17 ` Simon Horman
2024-03-05 17:35 ` Jesse Brandeburg
2024-03-06 16:46 ` Maciej Fijalkowski
2024-03-06 16:56 ` Maciej Fijalkowski
2024-03-07 1:33 ` Jesse Brandeburg
2024-03-07 1:41 ` Jesse Brandeburg [this message]
2024-03-07 16:10 ` Maciej Fijalkowski
2024-03-07 16:11 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9662b26f-3bba-41fb-90a6-3a6dbf98b5f5@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elliott@hpe.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).