From: Arnd Bergmann <arnd@arndb.de>
To: David Laight <David.Laight@aculab.com>
Cc: huangdaode <huangdaode@hisilicon.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"joe@perches.com" <joe@perches.com>,
"liguozhu@hisilicon.com" <liguozhu@hisilicon.com>,
"Yisen.Zhuang@huawei.com" <Yisen.Zhuang@huawei.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>,
"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
"kenneth-lee-2012@foxmail.com" <kenneth-lee-2012@foxmail.com>,
"xuwei5@hisilicon.com" <xuwei5@hisilicon.com>,
"lisheng011@huawei.com" <lisheng011@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lipeng321@huawei.com" <lipeng321@huawei.com>
Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning
Date: Fri, 16 Oct 2015 13:28:04 +0200 [thread overview]
Message-ID: <9667302.4m5v3ViVSt@wuerfel> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CBB97A6@AcuExch.aculab.com>
On Friday 16 October 2015 11:14:44 David Laight wrote:
> From: Arnd Bergmann
> > Sent: 16 October 2015 11:01
> > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that
> > has bits set that do not fit into a 32-bit variable on 64-bit architectures,
> > which causes a harmless gcc warning:
> ...
> > static void hix5hd2_port_disable(struct hix5hd2_priv *priv)
> > {
> > - writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
> > + writel_relaxed(~(u32)(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
> > writel_relaxed(0, priv->base + DESC_WR_RD_ENA);
>
> ISTM that just means that the constants shouldn't be 'long'.
Right, but that would probably mean changing the BIT() macro or not using it
here. In the past I've argued against using that macro, but I've given
up that fight.
Arnd
next prev parent reply other threads:[~2015-10-16 11:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 3:54 [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers huangdaode
2015-10-16 3:54 ` [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface huangdaode
2015-10-16 9:19 ` Arnd Bergmann
2015-10-16 3:54 ` [PATCH net-next v3 2/2] net: hisilicon fix a bug on Hisilicon Network Subsystem huangdaode
2015-10-16 9:30 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers Arnd Bergmann
2015-10-19 2:23 ` huangdaode
2015-10-16 9:30 ` [PATCH] net: hisilicon: include linux/vmalloc.h in dsaf Arnd Bergmann
2015-10-19 2:59 ` David Miller
2015-10-16 9:33 ` [PATCH] net: hisilicon: add OF dependency Arnd Bergmann
2015-10-16 17:03 ` kbuild test robot
2015-10-16 18:16 ` kbuild test robot
2015-10-16 18:22 ` Joe Perches
2015-10-16 18:39 ` kbuild test robot
2015-10-16 19:10 ` Arnd Bergmann
2015-10-19 3:01 ` David Miller
2015-10-16 10:00 ` [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann
2015-10-16 11:14 ` David Laight
2015-10-16 11:28 ` Arnd Bergmann [this message]
2015-10-16 18:04 ` Joe Perches
2015-10-16 18:50 ` Sergei Shtylyov
2015-10-16 21:22 ` Joe Perches
2015-10-16 21:42 ` Arnd Bergmann
2015-10-19 3:01 ` David Miller
2015-10-19 2:55 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9667302.4m5v3ViVSt@wuerfel \
--to=arnd@arndb.de \
--cc=David.Laight@aculab.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=joe@perches.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).